Fix uninitialized value in CFX_ByteString::FormatInteger

Fix uninitialized value in CFX_ByteString::FormatInteger

BUG=449845
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/0c61a738d2a8bef13c8fbe08c6df0b27238960ab

[jun_fang, 2015-02-10 23:04:47]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, tsepez@chromium.org

[jun_fang, 2015-02-10 23:04:48]

Hi Tom, please review this CL. Thanks!

[Tom Sepez, 2015-02-10 23:17:04]

LGTM

https://codereview.chromium.org/911293002/diff/1/core/include/fpdfapi/fpdf_ob...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/911293002/diff/1/core/include/fpdfapi/fpdf_ob...
core/include/fpdfapi/fpdf_objects.h:169: {

nit: prefer initializer list.

https://codereview.chromium.org/911293002/diff/1/core/include/fxcrt/fx_coordi...
File core/include/fxcrt/fx_coordinates.h (right):

https://codereview.chromium.org/911293002/diff/1/core/include/fxcrt/fx_coordi...
core/include/fxcrt/fx_coordinates.h:540: FX_RECT() { left = 0; top = 0; right =
0; bottom = 0; }
nit: prefer initializer list syntax, e.g.

FX_RECT() : left(0), top(0), right(0), bottom(0) { }

[jun_fang, 2015-02-11 00:04:07]

New patchsets have been uploaded after l-g-t-m from tsepez@chromium.org

[Tom Sepez, 2015-02-11 00:04:53]

Almost.

https://codereview.chromium.org/911293002/diff/10003/core/include/fpdfapi/fpd...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/911293002/diff/10003/core/include/fpdfapi/fpd...
core/include/fpdfapi/fpdf_objects.h:170: m_Type = PDFOBJ_NUMBER;
initialize m_type the same way.

[Tom Sepez, 2015-02-11 00:07:09]

Lets land it. LGTM++

https://codereview.chromium.org/911293002/diff/10003/core/include/fpdfapi/fpd...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/911293002/diff/10003/core/include/fpdfapi/fpd...
core/include/fpdfapi/fpdf_objects.h:170: m_Type = PDFOBJ_NUMBER;
On 2015/02/11 00:04:53, Tom Sepez wrote:
> initialize m_type the same way.

Argh.  Its in the base class.  Which means that the base class constructors
actually need to take this argument.  Let's not fix it now, but ideally this
would be
CPDF_Number() : CPDF_Object(PDFOBJ_NUMBER), m_bInteger(0) {}

[jun_fang, 2015-02-11 00:15:07]

Seems that base class' members can't be initialized in the derived class'
initializer list.

https://codereview.chromium.org/911293002/diff/10003/core/include/fpdfapi/fpd...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/911293002/diff/10003/core/include/fpdfapi/fpd...
core/include/fpdfapi/fpdf_objects.h:170: m_Type = PDFOBJ_NUMBER;
On 2015/02/11 00:07:09, Tom Sepez wrote:
> On 2015/02/11 00:04:53, Tom Sepez wrote:
> > initialize m_type the same way.
> 
> Argh.  Its in the base class.  Which means that the base class constructors
> actually need to take this argument.  Let's not fix it now, but ideally this
> would be
> CPDF_Number() : CPDF_Object(PDFOBJ_NUMBER), m_bInteger(0) {} 

I tried to fix it in the way that you proposed. But the compiler complained that
I couldn't initialize m_type in the initializer list.

[jun_fang, 2015-02-11 00:15:34]

Committed patchset #2 (id:10003) manually as
0c61a738d2a8bef13c8fbe08c6df0b27238960ab (presubmit successful).