Fix uninitialized value in CFX_ByteString::FormatInteger

core/include/fpdfapi/fpdf_objects.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef _FPDF_OBJECTS_
 #define _FPDF_OBJECTS_
 #ifndef _FXCRT_EXTENSION_
 #include "../fxcrt/fx_ext.h"
@@ skipping 147 matching lines @@
     static CPDF_Number*         Create(FX_BSTR str)
     {
         return FX_NEW CPDF_Number(str);
     }
 
     static CPDF_Number*         Create(FX_BOOL bInteger, void* pData)
     {
         return FX_NEW CPDF_Number(bInteger, pData);
     }
 
-    CPDF_Number()
+    CPDF_Number(): m_Integer(0) 
     {
         m_Type = PDFOBJ_NUMBER;

[Tom Sepez, 2015/02/11 00:04:53]

initialize m_type the same way.

[Tom Sepez, 2015/02/11 00:07:09]

Argh.  Its in the base class.  Which means that the base class constructors
actually need to take this argument.  Let's not fix it now, but ideally this
would be
CPDF_Number() : CPDF_Object(PDFOBJ_NUMBER), m_bInteger(0) {} 

[jun_fang, 2015/02/11 00:15:07]

I tried to fix it in the way that you proposed. But the compiler complained that
I couldn't initialize m_type in the initializer list. 

-    }
+    } 
 
     CPDF_Number(FX_BOOL bInteger, void* pData);
 
     CPDF_Number(int value);
 
     CPDF_Number(FX_FLOAT value);
 
     CPDF_Number(FX_BSTR str);
 
     FX_BOOL                                     Identical(CPDF_Number* pOther) const;
@@ skipping 601 matching lines @@
     }
 protected:
 
     CFX_MapPtrToPtr                     m_IndirectObjs;
 
     IPDF_DocParser*                     m_pParser;
 
     FX_DWORD                            m_LastObjNum;
 };
 #endif