Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: core/include/fpdfapi/fpdf_objects.h

Issue 911293002: Fix uninitialized value in CFX_ByteString::FormatInteger (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/include/fxcrt/fx_coordinates.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/include/fpdfapi/fpdf_objects.h
diff --git a/core/include/fpdfapi/fpdf_objects.h b/core/include/fpdfapi/fpdf_objects.h
index 1b7cb94583fe21f1d68a512defe1b4fb100fa5f7..ec052af41ab1f4ae86f45e1e2c4bebfa05ead10e 100644
--- a/core/include/fpdfapi/fpdf_objects.h
+++ b/core/include/fpdfapi/fpdf_objects.h
@@ -165,10 +165,10 @@ public:
return FX_NEW CPDF_Number(bInteger, pData);
}
- CPDF_Number()
+ CPDF_Number(): m_Integer(0)
{
m_Type = PDFOBJ_NUMBER;
Tom Sepez 2015/02/11 00:04:53 initialize m_type the same way.
Tom Sepez 2015/02/11 00:07:09 Argh. Its in the base class. Which means that th
jun_fang 2015/02/11 00:15:07 I tried to fix it in the way that you proposed. Bu
- }
+ }
CPDF_Number(FX_BOOL bInteger, void* pData);
« no previous file with comments | « no previous file | core/include/fxcrt/fx_coordinates.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698