Replace PlaceholderFrameOwner with RemoteBridgeFrameOwner.

Replace PlaceholderFrameOwner with RemoteBridgeFrameOwner.

Currently, with --site-per-process, PlaceholderFrameOwner is used as the FrameOwner for remote frames with a remote parent, and RemoteBridgeFrameOwner is used for local frames with a remote parent.

Having PlaceholderFrameOwners is proving to be problematic:
- when transitioning from a remote frame to local frame in initializeToReplaceRemoteFrame, we are currently leaving the PlaceholderFrameOwner in place, even though we should be switching it to RemoteBridgeFrameOwner.
- PlaceholderFrameOwner does not store SandboxFlags, which is needed to support sandbox flags replication.

This CL removes PlaceholderFrameOwner and replaces its usage with RemoteBridgeFrameOwner.  RemoteBridgeFrameOwner is lifted out of an anonymous namespace, because it needs to be referenced by WebLocalFrameImpl::initializeToReplaceRemoteFrame.

WebFrame::swap() probably also needs to be changed to update m_frame for RemoteBridgeFrameOwner.  I left this for a separate CL, since that probably needs some other plumbing and a test.  RemoteBridgeFrameOwner::m_frame isn't used anywhere at the moment, but it will be needed for plumbing dispatchLoad().

This also needs a small Chromium-side update: https://codereview.chromium.org/886923004

BUG=426512
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190010

[alexmos, 2015-02-11 20:52:42]

alexmos@chromium.org changed reviewers:
+ dcheng@chromium.org

[alexmos, 2015-02-11 21:19:42]

Daniel, could you please take a look?

[dcheng, 2015-02-11 21:57:24]

https://codereview.chromium.org/910313004/diff/1/Source/web/WebRemoteFrameImpl.h
File Source/web/WebRemoteFrameImpl.h (right):

https://codereview.chromium.org/910313004/diff/1/Source/web/WebRemoteFrameImp...
Source/web/WebRemoteFrameImpl.h:29: class RemoteBridgeFrameOwner : public
NoBaseWillBeGarbageCollectedFinalized<RemoteBridgeFrameOwner>, public FrameOwner
{
Perhaps we should move this to a new file? It seems a bit out of place in the
header.

https://codereview.chromium.org/910313004/diff/1/Source/web/WebRemoteFrameImp...
Source/web/WebRemoteFrameImpl.h:58: explicit
RemoteBridgeFrameOwner(PassRefPtrWillBeRawPtr<WebLocalFrameImpl>, SandboxFlags);
No need for explicit.

[alexmos, 2015-02-11 22:39:45]

https://codereview.chromium.org/910313004/diff/1/Source/web/WebRemoteFrameImpl.h
File Source/web/WebRemoteFrameImpl.h (right):

https://codereview.chromium.org/910313004/diff/1/Source/web/WebRemoteFrameImp...
Source/web/WebRemoteFrameImpl.h:29: class RemoteBridgeFrameOwner : public
NoBaseWillBeGarbageCollectedFinalized<RemoteBridgeFrameOwner>, public FrameOwner
{
On 2015/02/11 21:57:24, dcheng wrote:
> Perhaps we should move this to a new file? It seems a bit out of place in the
> header.

Done.

https://codereview.chromium.org/910313004/diff/1/Source/web/WebRemoteFrameImp...
Source/web/WebRemoteFrameImpl.h:58: explicit
RemoteBridgeFrameOwner(PassRefPtrWillBeRawPtr<WebLocalFrameImpl>, SandboxFlags);
On 2015/02/11 21:57:24, dcheng wrote:
> No need for explicit.

Done.

[dcheng, 2015-02-11 22:45:04]

lgtm

https://codereview.chromium.org/910313004/diff/20001/Source/web/RemoteBridgeF...
File Source/web/RemoteBridgeFrameOwner.h (right):

https://codereview.chromium.org/910313004/diff/20001/Source/web/RemoteBridgeF...
Source/web/RemoteBridgeFrameOwner.h:20: 
Nit: no newline.

[alexmos, 2015-02-11 22:47:11]

New patchsets have been uploaded after l-g-t-m from dcheng@chromium.org

[alexmos, 2015-02-11 22:49:47]

https://codereview.chromium.org/910313004/diff/20001/Source/web/RemoteBridgeF...
File Source/web/RemoteBridgeFrameOwner.h (right):

https://codereview.chromium.org/910313004/diff/20001/Source/web/RemoteBridgeF...
Source/web/RemoteBridgeFrameOwner.h:20: 
On 2015/02/11 22:45:04, dcheng wrote:
> Nit: no newline.

Done.  I guess git cl format did the wrong thing?

[alexmos, 2015-02-11 22:50:20]

alexmos@chromium.org changed reviewers:
+ japhet@chromium.org

[alexmos, 2015-02-11 22:50:21]

Nate, could you please provide an owner review?

[Nate Chapin, 2015-02-11 23:16:39]

lgtm

[alexmos, 2015-02-11 23:24:56]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2015-02-11 23:25:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/910313004/40001

[commit-bot: I haz the power, 2015-02-12 00:20:14]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190010