Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 886923004: Update createRemoteChild to pass SandboxFlags (Closed)

Created:
5 years, 10 months ago by alexmos
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update createRemoteChild to pass SandboxFlags. Until now, the FrameOwner for remote frames with a remote parent was a PlaceholderFrameOwner, which couldn't store sandbox flags. The Blink side of this CL replaces PlaceholderFrameOwner with a RemoteBridgeFrameOwner, which does store sandbox flags, and with this change, we will initialize them using the replicated state that's already passed in to CreateFrameProxy. Corresponding Blink patch (needs to land first): https://codereview.chromium.org/910313004/ BUG=426512 Committed: https://crrev.com/81a14d049fd77caf3b5f97cdf446f31a500b5bad Cr-Commit-Position: refs/heads/master@{#316604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/render_frame_proxy.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
alexmos
Charlie, could you please review this really small CL?
5 years, 10 months ago (2015-02-11 23:02:05 UTC) #2
Charlie Reis
LGTM
5 years, 10 months ago (2015-02-11 23:19:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886923004/1
5 years, 10 months ago (2015-02-13 15:06:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24824)
5 years, 10 months ago (2015-02-13 16:11:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886923004/1
5 years, 10 months ago (2015-02-17 17:59:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 17:59:54 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:00:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81a14d049fd77caf3b5f97cdf446f31a500b5bad
Cr-Commit-Position: refs/heads/master@{#316604}

Powered by Google App Engine
This is Rietveld 408576698