Source/web/WebLocalFrameImpl.cpp - Issue 910313004: Replace PlaceholderFrameOwner with RemoteBridgeFrameOwner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 910313004: Replace PlaceholderFrameOwner with RemoteBridgeFrameOwner. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Nit: remove newline Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 070ca6ae376710c82c23e786451bdef42cd3bc99..c82f6e839938dcaacda0ae18b49e8423859b9548 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -204,6 +204,7 @@

#include "web/MIDIClientProxy.h"

#include "web/NotificationPermissionClientImpl.h"

#include "web/PageOverlay.h"

+#include "web/RemoteBridgeFrameOwner.h"

#include "web/SharedWorkerRepositoryClientImpl.h"

#include "web/SuspendableScriptExecutor.h"

#include "web/TextFinder.h"

@@ -1855,7 +1856,7 @@ void WebLocalFrameImpl::loadJavaScriptURL(const KURL& url)

void WebLocalFrameImpl::initializeToReplaceRemoteFrame(WebRemoteFrame* oldWebFrame)

{

Frame* oldFrame = toCoreFrame(oldWebFrame);

- OwnPtrWillBePersistent<FrameOwner> tempOwner = adoptPtrWillBeNoop(new PlaceholderFrameOwner());

+ OwnPtrWillBePersistent<FrameOwner> tempOwner = RemoteBridgeFrameOwner::create(nullptr, SandboxNone);

m_frame = LocalFrame::create(&m_frameLoaderClientImpl, oldFrame->host(), tempOwner.get());

m_frame->setOwner(oldFrame->owner());

m_frame->tree().setName(oldFrame->tree().name());

« no previous file with comments | « Source/web/RemoteBridgeFrameOwner.cpp ('k') | Source/web/WebRemoteFrameImpl.h » ('j') | no next file with comments »