Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 910083002: Constify and use LayoutStyle reference in layout/ (Closed)

Created:
5 years, 10 months ago by Julien - ping for review
Modified:
5 years, 10 months ago
Reviewers:
dsinclair, Timothy Loh
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Constify and use LayoutStyle reference in layout/ These classes were missed as they moved while I worked on rendering/ classes. Hopefully one of the last steps towards making LayoutObject::style() return a const LayoutStyle. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189869

Patch Set 1 #

Patch Set 2 : Rebaseline after RenderStyle -> LayoutStyle #

Patch Set 3 : Rebaselined again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -273 lines) Patch
M Source/core/layout/Layer.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/Layer.cpp View 1 11 chunks +19 lines, -19 lines 0 comments Download
M Source/core/layout/LayerScrollableArea.cpp View 1 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutCounter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutCounter.cpp View 1 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutLayerModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutSliderContainer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTable.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutTableCell.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableCell.cpp View 1 9 chunks +29 lines, -29 lines 0 comments Download
M Source/core/layout/LayoutTableSection.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/layout/compositing/CompositedLayerMapping.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 11 chunks +32 lines, -30 lines 0 comments Download
M Source/core/layout/compositing/CompositingReasonFinder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/CompositingReasonFinder.cpp View 1 4 chunks +20 lines, -20 lines 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/line/EllipsisBox.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 7 chunks +26 lines, -26 lines 0 comments Download
M Source/core/layout/line/InlineIterator.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/line/LineBreaker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/style/LayoutStyle.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.cpp View 1 2 6 chunks +28 lines, -34 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 2 chunks +7 lines, -10 lines 0 comments Download
M Source/core/layout/svg/SVGResourcesCache.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/SVGResourcesCache.cpp View 1 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/layout/svg/SVGTextMetrics.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/FilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/SVGPaintContext.cpp View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/paint/TableCellPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Julien - ping for review
5 years, 10 months ago (2015-02-10 01:25:02 UTC) #2
Julien - ping for review
5 years, 10 months ago (2015-02-10 04:52:57 UTC) #4
Timothy Loh
On 2015/02/10 04:52:57, Julien Chaffraix - AEST wrote: lgtm
5 years, 10 months ago (2015-02-10 05:02:33 UTC) #5
Julien - ping for review
Thanks Tim!
5 years, 10 months ago (2015-02-10 05:20:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910083002/40001
5 years, 10 months ago (2015-02-10 05:20:49 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 05:24:33 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189869

Powered by Google App Engine
This is Rietveld 408576698