Source/core/rendering/svg/RenderSVGContainer.cpp - Issue 910083002: Constify and use LayoutStyle reference in layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGContainer.cpp

Issue 910083002: Constify and use LayoutStyle reference in layout/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebaselined again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGContainer.cpp

diff --git a/Source/core/rendering/svg/RenderSVGContainer.cpp b/Source/core/rendering/svg/RenderSVGContainer.cpp

index 05711a827b28e48d8e8b6fb72dae0c44d1257efd..ffe5446e1f22f11f3d3a4f63010acde230a9829a 100644

--- a/Source/core/rendering/svg/RenderSVGContainer.cpp

+++ b/Source/core/rendering/svg/RenderSVGContainer.cpp

@@ -77,7 +77,7 @@ void RenderSVGContainer::layout()

void RenderSVGContainer::addChild(LayoutObject* child, LayoutObject* beforeChild)

{

RenderSVGModelObject::addChild(child, beforeChild);

- SVGResourcesCache::clientWasAddedToTree(child, child->style());

+ SVGResourcesCache::clientWasAddedToTree(child, child->styleRef());

bool shouldIsolateDescendants = (child->isBlendingAllowed() && child->style()->hasBlendMode()) || child->hasNonIsolatedBlendingDescendants();

if (shouldIsolateDescendants)

@@ -104,7 +104,7 @@ void RenderSVGContainer::styleDidChange(StyleDifference diff, const LayoutStyle*

{

RenderSVGModelObject::styleDidChange(diff, oldStyle);

- bool hadIsolation = oldStyle && !isSVGHiddenContainer() && SVGLayoutSupport::willIsolateBlendingDescendantsForStyle(oldStyle);

+ bool hadIsolation = oldStyle && !isSVGHiddenContainer() && SVGLayoutSupport::willIsolateBlendingDescendantsForStyle(*oldStyle);

bool isolationChanged = hadIsolation == !SVGLayoutSupport::willIsolateBlendingDescendantsForObject(this);

if (!parent() || !isolationChanged)