Source/core/layout/svg/SVGTextLayoutEngine.cpp - Issue 910083002: Constify and use LayoutStyle reference in layout/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 910083002: Constify and use LayoutStyle reference in layout/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebaselined again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/svg/SVGTextLayoutEngine.cpp

diff --git a/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/Source/core/layout/svg/SVGTextLayoutEngine.cpp

index 78e54e99ed586bda62b638fad622c35ba6bba4b0..99fd53aa177abd54869d51546ffecbd307822dd3 100644

--- a/Source/core/layout/svg/SVGTextLayoutEngine.cpp

+++ b/Source/core/layout/svg/SVGTextLayoutEngine.cpp

@@ -245,12 +245,11 @@ void SVGTextLayoutEngine::layoutInlineTextBox(SVGInlineTextBox* textBox)

ASSERT(text.parent()->node());

ASSERT(text.parent()->node()->isSVGElement());

- const LayoutStyle* style = text.style();

- ASSERT(style);

+ const LayoutStyle& style = text.styleRef();

textBox->clearTextFragments();

- m_isVerticalText = style->svgStyle().isVerticalWritingMode();

- layoutTextOnLineOrPath(textBox, text, *style);

+ m_isVerticalText = style.svgStyle().isVerticalWritingMode();

+ layoutTextOnLineOrPath(textBox, text, style);

if (m_inPathLayout) {

m_pathLayoutBoxes.append(textBox);