Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2304)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 90933002: Delete InputMethodEngine::CreateEngine and call the InputMethodEngineIBus contructor directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add OWNER file Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc
index 185873e1c03d28a0738a5221ce384788867feac8..fe3e6b200e8ba2370840f1560c66846a734a257f 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc
@@ -48,31 +48,4 @@ InputMethodEngine::CandidateWindowProperty::~CandidateWindowProperty() {
InputMethodEngine::Observer::~Observer() {
}
-
-InputMethodEngine* InputMethodEngine::CreateEngine(
- InputMethodEngine::Observer* observer,
- const char* engine_name,
- const char* extension_id,
- const char* engine_id,
- const char* description,
- const std::vector<std::string>& languages,
- const std::vector<std::string>& layouts,
- const GURL& options_page,
- const GURL& input_view,
- std::string* error) {
-
- InputMethodEngineIBus* engine = new InputMethodEngineIBus();
- engine->Initialize(observer,
- engine_name,
- extension_id,
- engine_id,
- description,
- languages,
- layouts,
- options_page,
- input_view,
- error);
- return engine;
-}
-
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698