Start compiling to Fletch bytecodes.

Start compiling to Fletch bytecodes.

R=kasperl@google.com

Committed: https://github.com/dart-lang/fletch/commit/d5d5888f71c30484847678bf35851966f85ff6a4

[ahe, 2015-02-10 19:05:09]

ahe@google.com changed reviewers:
+ kasperl@google.com

[ahe, 2015-02-10 19:05:10]

How to run:

.../dart/sdk/bin/dart -ppackage/ -c package:fletchc/dart2js_bridge.dart
lib/simple_system/system.dart

Which prints:

lib/simple_system/system.dart:7:1:
Hint: Compiling _entry
_entry(int mainArity) {
^^^^^^
Constants
  #0: Hello, World
  #1: function(_printString)
  #2: 1
  #3: function(_halt)
Bytecodes:
  0: load const @0
  5: invoke static @1
  10: pop
  11: load const @2
  16: invoke static @3
  21: pop

[kasperl, 2015-02-10 19:56:57]

LGTM!

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
File pkg/fletchc/lib/dart2js_bridge.dart (right):

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:5: import 'dart:io' show
Maybe give this a library a name?

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:48: myLocation =
My usual preference is to add a few more local variables to "sequentialize" the
somewhat complicated expression (and avoid the long lines). I prefer stepping
through that in a debugger and I prefer that I get names for the individual
expressions.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:150: void
enqueueHelpers(dart2js.ResolutionEnqueuer world, dart2js.Registry registry) {
Long line.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:183: class FletchVisitor extends
SemanticVisitor {
FletchMethodVisitor perhaps?

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:197: int id = constants.putIfAbsent(element,
() => constants.length);
I'd consider adding a helper method for turning a constant into the
corresponding index / id.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:215: print("literal ${node}");
Maybe just remove this printing again?

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:231: node.visitChildren(this);
How about moving the pop from visitStaticMethodInvocation here?

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:236: void visitParameterAssignment(SendSet
node, ParameterElement element, Node rhs);
Long line.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:286: void
visitTopLevelFieldAssignment(SendSet node, FieldElement element, Node rhs);
Long line.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:327: void
visitTypeVariableTypeLiteralAccess(Send node, TypeVariableElement element);
Long line.

[ahe, 2015-02-10 21:38:08]

Thank you, Kasper!

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
File pkg/fletchc/lib/dart2js_bridge.dart (right):

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:231: node.visitChildren(this);
On 2015/02/10 19:56:56, kasperl wrote:
> How about moving the pop from visitStaticMethodInvocation here?

Yes, of course!

[ahe, 2015-02-11 10:32:00]

I'll address your comments in a follow-up CL.

[ahe, 2015-02-11 10:32:20]

Committed patchset #1 (id:1) manually as
d5d5888f71c30484847678bf35851966f85ff6a4 (presubmit successful).

[ahe, 2015-02-11 13:47:18]

Thank you, Kasper!

I went a little overboard and addressed your comments in
https://codereview.chromium.org/918613002 as well as tried to make the compiler
easier to use based on Luke API design review yesterday.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
File pkg/fletchc/lib/dart2js_bridge.dart (right):

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:5: import 'dart:io' show
On 2015/02/10 19:56:57, kasperl wrote:
> Maybe give this a library a name?

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:48: myLocation =
On 2015/02/10 19:56:57, kasperl wrote:
> My usual preference is to add a few more local variables to "sequentialize"
the
> somewhat complicated expression (and avoid the long lines). I prefer stepping
> through that in a debugger and I prefer that I get names for the individual
> expressions.

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:150: void
enqueueHelpers(dart2js.ResolutionEnqueuer world, dart2js.Registry registry) {
On 2015/02/10 19:56:57, kasperl wrote:
> Long line.

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:183: class FletchVisitor extends
SemanticVisitor {
On 2015/02/10 19:56:56, kasperl wrote:
> FletchMethodVisitor perhaps?

I think I like "BytecodeBuilder".

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:197: int id = constants.putIfAbsent(element,
() => constants.length);
On 2015/02/10 19:56:56, kasperl wrote:
> I'd consider adding a helper method for turning a constant into the
> corresponding index / id.

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:215: print("literal ${node}");
On 2015/02/10 19:56:57, kasperl wrote:
> Maybe just remove this printing again?

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:236: void visitParameterAssignment(SendSet
node, ParameterElement element, Node rhs);
On 2015/02/10 19:56:57, kasperl wrote:
> Long line.

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:286: void
visitTopLevelFieldAssignment(SendSet node, FieldElement element, Node rhs);
On 2015/02/10 19:56:57, kasperl wrote:
> Long line.

Done.

https://codereview.chromium.org/909223002/diff/1/pkg/fletchc/lib/dart2js_brid...
pkg/fletchc/lib/dart2js_bridge.dart:327: void
visitTypeVariableTypeLiteralAccess(Send node, TypeVariableElement element);
On 2015/02/10 19:56:57, kasperl wrote:
> Long line.

Done.