Refactor implementation to address review comments and API design suggestions from Luke.

Refactor implementation to address review comments and API design suggestions from Luke.

R=kasperl@google.com

Committed: https://github.com/dart-lang/fletch/commit/311cb6f1051cef61787918bb4fc0a8bcd4a1d42a

[ahe, 2015-02-11 13:48:30]

ahe@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2015-02-11 13:50:29]

LGTM.

https://codereview.chromium.org/918613002/diff/1/pkg/fletchc/lib/src/bytecode...
File pkg/fletchc/lib/src/bytecode_builder.dart (right):

https://codereview.chromium.org/918613002/diff/1/pkg/fletchc/lib/src/bytecode...
pkg/fletchc/lib/src/bytecode_builder.dart:21: class BytecodeBuilder extends
SemanticVisitor {
I think it might make sense to have three different visitors long-term:

   - one for effect
   - one for value
   - one for branching

Let's discuss that offline.

[ahe, 2015-02-11 14:35:25]

Thank you, Kasper!

https://codereview.chromium.org/918613002/diff/1/pkg/fletchc/lib/src/bytecode...
File pkg/fletchc/lib/src/bytecode_builder.dart (right):

https://codereview.chromium.org/918613002/diff/1/pkg/fletchc/lib/src/bytecode...
pkg/fletchc/lib/src/bytecode_builder.dart:21: class BytecodeBuilder extends
SemanticVisitor {
On 2015/02/11 13:50:29, kasperl wrote:
> I think it might make sense to have three different visitors long-term:
> 
>    - one for effect
>    - one for value
>    - one for branching
> 
> Let's discuss that offline.

That makes a lot of sense. I'll try to get started on that immediately, and I'll
really need your help to get it right.

[ahe, 2015-02-11 14:37:26]

Committed patchset #1 (id:1) manually as
311cb6f1051cef61787918bb4fc0a8bcd4a1d42a (presubmit successful).