Issue 9068001: Merge 114806 - Include the information whether the tab is already in a tab strip with the retarge...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9068001: Merge 114806 - Include the information whether the tab is already in a tab strip with the retarge... (Closed)

Created:
8 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/963/src/

Visibility:
Public.

More Reviews

Description

Merge 114806 - Include the information whether the tab is already in a tab strip with the retargeting details BUG=107759 TEST=added a DCHECK. Without the fix, the DCHECK would trigger in ExtensionApiTest.WebNavigationOpenTab Review URL: http://codereview.chromium.org/8964014 TBR=jochen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116089

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -48 lines)			Patch
M	chrome/browser/extensions/extension_tab_id_map.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.cc	View	6 chunks	+21 lines, -10 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
A +	chrome/browser/tab_contents/retargeting_details.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/navigation_details.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages