Issue 8964014: Include the information whether the tab is already in a tab strip with the retargeting details

Issue 8964014: Include the information whether the tab is already in a tab strip with the retargeting details (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)

Modified:
9 years ago

Reviewers:
Avi (use Gerrit), battre

CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Include the information whether the tab is already in a tab strip with the retargeting details BUG=107759 TEST=added a DCHECK. Without the fix, the DCHECK would trigger in ExtensionApiTest.WebNavigationOpenTab Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114806

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 3

Patch Set 3 : updates #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -49 lines)			Patch
M	chrome/browser/extensions/extension_tab_id_map.cc	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_api.cc	View	1 2	6 chunks	+21 lines, -10 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
A	chrome/browser/tab_contents/retargeting_details.h	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/navigation_details.h	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8964014/1

9 years ago (2011-12-16 13:32:51 UTC) #3

jochen (gone - plz use gerrit)

PTAL It turns out that I put the original code in that order for a ...

9 years ago (2011-12-16 14:56:20 UTC) #4

Avi (use Gerrit)

9 years ago (2011-12-16 15:25:15 UTC) #5

lgtm

http://codereview.chromium.org/8964014/diff/6001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_webnavigation_api.cc (right):

http://codereview.chromium.org/8964014/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_webnavigation_api.cc:177: // path is
excercised by ExtensionApiTest.WebNavigationRequestOpenTab.
typo in 'exercised'.

http://codereview.chromium.org/8964014/diff/6001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_webnavigation_api.cc:427: // doesn't yet
have a wrapper, or if it isn't yet inserted into a tab strip,
Grammar is slightly off. "If the TabContents was created as a response to an IPC
from a render (and therefore doesn't yet have a wrapper), or if it isn't ..."

http://codereview.chromium.org/8964014/diff/6001/chrome/common/chrome_notific...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/8964014/diff/6001/chrome/common/chrome_notific...
chrome/common/chrome_notification_types.h:81: // corresponding to the browser
context in which the new tab will live.
s/browser context/profile/ ?

Expand Messages | Collapse Messages