chrome/browser/tab_contents/render_view_context_menu.cc - Issue 9068001: Merge 114806 - Include the information whether the tab is already in a tab strip with the retarge...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 9068001: Merge 114806 - Include the information whether the tab is already in a tab strip with the retarge... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/963/src/

Patch Set: Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webnavigation_api.cc ('k') | chrome/browser/tab_contents/render_view_host_delegate_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

===================================================================

--- chrome/browser/tab_contents/render_view_context_menu.cc (revision 116088)

+++ chrome/browser/tab_contents/render_view_context_menu.cc (working copy)

@@ -40,6 +40,7 @@

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/spellchecker/spellcheck_host.h"

#include "chrome/browser/spellchecker/spellcheck_host_metrics.h"

+#include "chrome/browser/tab_contents/retargeting_details.h"

#include "chrome/browser/tab_contents/spellchecker_submenu_observer.h"

#include "chrome/browser/tab_contents/spelling_menu_observer.h"

#include "chrome/browser/translate/translate_manager.h"

@@ -50,6 +51,7 @@

#include "chrome/browser/ui/tab_contents/per_tab_prefs_tab_helper.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

#include "chrome/common/chrome_constants.h"

+#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/print_messages.h"

@@ -1817,16 +1819,17 @@

transition, false));

if (new_contents) {

- content::RetargetingDetails details;

+ RetargetingDetails details;

details.source_tab_contents = source_tab_contents_;

details.source_frame_id = frame_id;

details.target_url = url;

details.target_tab_contents = new_contents;

+ details.not_yet_in_tabstrip = false;

content::NotificationService::current()->Notify(

- content::NOTIFICATION_RETARGETING,

- content::Source<content::BrowserContext>(

- source_tab_contents_->browser_context()),

- content::Details<content::RetargetingDetails>(&details));

+ chrome::NOTIFICATION_RETARGETING,

+ content::Source<Profile>(Profile::FromBrowserContext(

+ source_tab_contents_->browser_context())),

+ content::Details<RetargetingDetails>(&details));

}