content/browser/frame_host/navigation_entry_impl.cc - Issue 906283003: PlzNavigate: Support data urls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 906283003: PlzNavigate: Support data urls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Charlie's comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl.cc

diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc

index 7e391929596c3646e756ad9de18a3f26443fd89e..0c59287cad54138578b2268a655a9aee7bd0f5cd 100644

--- a/content/browser/frame_host/navigation_entry_impl.cc

+++ b/content/browser/frame_host/navigation_entry_impl.cc

@@ -351,4 +351,8 @@ void NavigationEntryImpl::SetScreenshotPNGData(

UMA_HISTOGRAM_MEMORY_KB("Overscroll.ScreenshotSize", screenshot_->size());

}

+GURL NavigationEntryImpl::GetHistoryURLForDataURL() const {

+ return GetBaseURLForDataURL().is_empty()? GURL() : GetVirtualURL();

nasko 2015/02/26 17:35:24 nit: space still needed before "?"

clamy 2015/02/27 12:53:59 Done.

} // namespace content