Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 906283003: PlzNavigate: Support data urls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Charlie's comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.h
diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h
index 948dbd1de14c8f64bd58ada794b97c2fc00e871e..56e993d7af3bbbee19f9378eecdaea72bb20ec82 100644
--- a/content/browser/frame_host/navigation_request.h
+++ b/content/browser/frame_host/navigation_request.h
@@ -52,6 +52,10 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
FAILED,
};
+ // Helper function to determine if the navigation request to |url| should be
+ // sent to the network stack.
+ static bool ShouldMakeNetworkRequest(const GURL& url);
+
// Creates a request for a browser-intiated navigation.
static scoped_ptr<NavigationRequest> CreateBrowserInitiated(
FrameTreeNode* frame_tree_node,
@@ -70,11 +74,11 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {
~NavigationRequest() override;
- // Called on the UI thread by the Navigator to start the navigation on the IO
- // thread.
+ // Called on the UI thread by the Navigator to start the navigation. Returns
+ // whether a request was made on the IO thread.
// TODO(clamy): see if ResourceRequestBody could be un-refcounted to avoid
// threading subtleties.
- void BeginNavigation();
+ bool BeginNavigation();
const CommonNavigationParams& common_params() const { return common_params_; }

Powered by Google App Engine
This is Rietveld 408576698