content/browser/frame_host/navigation_entry_impl.cc - Issue 906283003: PlzNavigate: Support data urls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 906283003: PlzNavigate: Support data urls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Charlie's comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.h ('k') | content/browser/frame_host/navigation_request.h » ('j') | content/browser/frame_host/navigation_request.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/frame_host/navigation_entry_impl.h"	5 #include "content/browser/frame_host/navigation_entry_impl.h"

6	6

7 #include "base/metrics/histogram.h"	7 #include "base/metrics/histogram.h"

8 #include "base/strings/string_util.h"	8 #include "base/strings/string_util.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "content/public/common/content_constants.h"	10 #include "content/public/common/content_constants.h"

(...skipping 333 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
344 #endif	344 #endif

345 }	345 }

346	346

347 void NavigationEntryImpl::SetScreenshotPNGData(	347 void NavigationEntryImpl::SetScreenshotPNGData(

348 scoped_refptr<base::RefCountedBytes> png_data) {	348 scoped_refptr<base::RefCountedBytes> png_data) {

349 screenshot_ = png_data;	349 screenshot_ = png_data;

350 if (screenshot_.get())	350 if (screenshot_.get())

351 UMA_HISTOGRAM_MEMORY_KB("Overscroll.ScreenshotSize", screenshot_->size());	351 UMA_HISTOGRAM_MEMORY_KB("Overscroll.ScreenshotSize", screenshot_->size());

352 }	352 }

353	353

	354 GURL NavigationEntryImpl::GetHistoryURLForDataURL() const {

	355 return GetBaseURLForDataURL().is_empty()? GURL() : GetVirtualURL();
	nasko 2015/02/26 17:35:24 nit: space still needed before "?" nit: space still needed before "?" clamy 2015/02/27 12:53:59 Done. Show quoted text On 2015/02/26 17:35:24, nasko wrote: > nit: space still needed before "?" Done.
	356 }

	357

354 } // namespace content	358 } // namespace content

OLD	NEW