5 years, 10 months ago
(2015-02-09 18:02:56 UTC)
#2
PTAL.
Ken Russell (switch to Gerrit)
LGTM overall, but could you please try to add tests that catch the previous crash? ...
5 years, 10 months ago
(2015-02-10 16:12:56 UTC)
#3
LGTM overall, but could you please try to add tests that catch the previous
crash? Can you provoke it by just not playing the media element?
Raymond Toy
On 2015/02/10 16:12:56, Ken Russell wrote: > LGTM overall, but could you please try to ...
5 years, 10 months ago
(2015-02-17 22:15:30 UTC)
#4
On 2015/02/10 16:12:56, Ken Russell wrote:
> LGTM overall, but could you please try to add tests that catch the previous
> crash? Can you provoke it by just not playing the media element?
Not playing the element doesn't invoke the issue. I tried to duplicate some of
what youtube and AudioEQ do, but have not figured out exactly what causes the
webMediaPlayer to be 0 for some period of time.
Issue filed to create a test for this:
https://code.google.com/p/chromium/issues/detail?id=459362
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
5 years, 10 months ago
(2015-02-17 22:16:17 UTC)
#5
Issue 905393002: Check for valid webMediaPlayer() before using it.
(Closed)
Created 5 years, 10 months ago by Raymond Toy
Modified 5 years, 10 months ago
Reviewers: hongchan, Ken Russell (switch to Gerrit)
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 0