Issue 905023002: Revert https://codereview.chromium.org/520433002

Issue 905023002: Revert https://codereview.chromium.org/520433002 (Closed)

Created:
5 years, 10 months ago by Raymond Toy

Modified:
5 years, 10 months ago

Reviewers:
pdr.

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert https://codereview.chromium.org/520433002 This is a partial revert that removes the CORS checks. All the other changes were in support of adding the 3 lines for the CORS checks to silence the output on failure. Tests are also removed. BUG=456312 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189724

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -212 lines)			Patch
D	LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin.html	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-allowed.html	View	1	1 chunk	+0 lines, -46 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-allowed-expected.txt	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-expected.txt	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-with-credentials.html	View	1	1 chunk	+0 lines, -46 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-with-credentials-expected.txt	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-same-origin.html	View	1	1 chunk	+0 lines, -38 lines	0 comments	Download
D	LayoutTests/http/tests/security/media-element-audio-source-node-same-origin-expected.txt	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/modules/webaudio/MediaElementAudioSourceNode.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

pdr.

This doesn't appear to be a complete revert of the original patch. Could you either ...

5 years, 10 months ago (2015-02-06 23:07:35 UTC) #2

Raymond Toy

On 2015/02/06 23:07:35, pdr wrote: > This doesn't appear to be a complete revert of ...

5 years, 10 months ago (2015-02-06 23:11:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905023002/20001

5 years, 10 months ago (2015-02-06 23:13:26 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-07 00:41:45 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189724