Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 905393002: Check for valid webMediaPlayer() before using it. (Closed)

Created:
5 years, 10 months ago by Raymond Toy
Modified:
5 years, 10 months ago
CC:
blink-reviews, pdr.
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check for valid webMediaPlayer() before using it. This fixes the underlying issue in bug 456312 and reverts the revert in https://codereview.chromium.org/905023002, adding the fix and the layout tests back. Manually tested by visiting youtube.com and clicking on videos, before the current video is finished. This requires the Audio EQ (HTML5 Audio Equalizer for Chrome) extension to be added and enabled. BUG=456312, 313939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190367

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Raymond Toy
PTAL.
5 years, 10 months ago (2015-02-09 18:02:56 UTC) #2
Ken Russell (switch to Gerrit)
LGTM overall, but could you please try to add tests that catch the previous crash? ...
5 years, 10 months ago (2015-02-10 16:12:56 UTC) #3
Raymond Toy
On 2015/02/10 16:12:56, Ken Russell wrote: > LGTM overall, but could you please try to ...
5 years, 10 months ago (2015-02-17 22:15:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905393002/1
5 years, 10 months ago (2015-02-17 22:16:50 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 23:49:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190367

Powered by Google App Engine
This is Rietveld 408576698