DescriptionRevert of [telemetry] Add a V8GCTimes measurement and benchmarks. (patchset #2 id:20001 of https://codereview.chromium.org/898673005/)
Reason for revert:
Failing on mac:
http://chromegw/i/chromium.perf/builders/Mac%2010.9%20Perf%20%281%29/builds/2017
Original issue's description:
> [telemetry] Add a V8GCTimes measurement and benchmarks.
>
> Replaces the v8_stats metric with a v8_gc_times
> measurement. This new measurement measures the amount of
> time spent in GC during the whole benchmark rather than
> just during gestures.
>
> The following gc metrics are measured:
> v8_gc_incremental_marking
> v8_gc_incremental_marking_idle_deadline_overrun
> v8_gc_incremental_marking_outside_idle
> v8_gc_incremental_marking_percentage_idle
> v8_gc_mark_compactor
> v8_gc_mark_compactor_idle_deadline_overrun
> v8_gc_mark_compactor_outside_idle
> v8_gc_mark_compactor_percentage_idle
> v8_gc_scavenger
> v8_gc_scavenger_idle_deadline_overrun
> v8_gc_scavenger_outside_idle
> v8_gc_scavenger_percentage_idle
> v8_gc_total
> v8_gc_total_idle_deadline_overrun
> v8_gc_total_outside_idle
>
> It also measures the duration of the measurement and the
> amount of CPU time used.
>
> The v8_garbage_collection_cases benchmark is modified to
> use this new v8_gc_times measurement, and v8.top_25_smooth
> and v8.key_mobile_sites_smooth benchmarks have been added.
>
> Since v8_garbage_collection_cases was the only benchmark to
> use the is_fast metric type, and these measurements are now
> done as part of the v8_gc_times measurement now, this CL
> also removes the fast metric type.
>
> Perf Sherrifs: Since this CL changes he way in which the GC
> measurements are done it may cause a movement in the
> v8_garbage_collection_cases benchmarks.
>
> Committed: https://crrev.com/452de5927e54e1da0d57a4b2df8b447f4d442360
> Cr-Commit-Position: refs/heads/master@{#314868}
TBR=hpayer@chromium.org,rmcilroy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/97171c784ca345a9514892858eb1b26d804ab7a5
Cr-Commit-Position: refs/heads/master@{#315035}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|