Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 904903002: Revert of [telemetry] Add a V8GCTimes measurement and benchmarks. (Closed)

Created:
5 years, 10 months ago by Sami
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, jochen (gone - plz use gerrit), Hannes Payer (out of office), picksi1, ulan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [telemetry] Add a V8GCTimes measurement and benchmarks. (patchset #2 id:20001 of https://codereview.chromium.org/898673005/) Reason for revert: Failing on mac: http://chromegw/i/chromium.perf/builders/Mac%2010.9%20Perf%20%281%29/builds/2017 Original issue's description: > [telemetry] Add a V8GCTimes measurement and benchmarks. > > Replaces the v8_stats metric with a v8_gc_times > measurement. This new measurement measures the amount of > time spent in GC during the whole benchmark rather than > just during gestures. > > The following gc metrics are measured: > v8_gc_incremental_marking > v8_gc_incremental_marking_idle_deadline_overrun > v8_gc_incremental_marking_outside_idle > v8_gc_incremental_marking_percentage_idle > v8_gc_mark_compactor > v8_gc_mark_compactor_idle_deadline_overrun > v8_gc_mark_compactor_outside_idle > v8_gc_mark_compactor_percentage_idle > v8_gc_scavenger > v8_gc_scavenger_idle_deadline_overrun > v8_gc_scavenger_outside_idle > v8_gc_scavenger_percentage_idle > v8_gc_total > v8_gc_total_idle_deadline_overrun > v8_gc_total_outside_idle > > It also measures the duration of the measurement and the > amount of CPU time used. > > The v8_garbage_collection_cases benchmark is modified to > use this new v8_gc_times measurement, and v8.top_25_smooth > and v8.key_mobile_sites_smooth benchmarks have been added. > > Since v8_garbage_collection_cases was the only benchmark to > use the is_fast metric type, and these measurements are now > done as part of the v8_gc_times measurement now, this CL > also removes the fast metric type. > > Perf Sherrifs: Since this CL changes he way in which the GC > measurements are done it may cause a movement in the > v8_garbage_collection_cases benchmarks. > > Committed: https://crrev.com/452de5927e54e1da0d57a4b2df8b447f4d442360 > Cr-Commit-Position: refs/heads/master@{#314868} TBR=hpayer@chromium.org,rmcilroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/97171c784ca345a9514892858eb1b26d804ab7a5 Cr-Commit-Position: refs/heads/master@{#315035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -494 lines) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +7 lines, -27 lines 0 comments Download
D tools/perf/measurements/v8_gc_times.py View 1 chunk +0 lines, -191 lines 0 comments Download
D tools/perf/measurements/v8_gc_times_unittest.py View 1 chunk +0 lines, -262 lines 0 comments Download
M tools/perf/page_sets/garbage_collection_cases.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 6 chunks +12 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
A tools/telemetry/telemetry/web_perf/metrics/fast_metric.py View 1 chunk +101 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py View 1 chunk +216 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_perf/metrics/v8_stats.py View 1 chunk +64 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 4 chunks +12 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 6 chunks +55 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 5 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
Created Revert of [telemetry] Add a V8GCTimes measurement and benchmarks.
5 years, 10 months ago (2015-02-06 15:05:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904903002/1
5 years, 10 months ago (2015-02-06 15:06:10 UTC) #2
Sami
Failing on the Linux bot too: http://chromegw/i/chromium.perf/builders/Linux%20Perf%20(1)
5 years, 10 months ago (2015-02-06 15:06:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 15:06:45 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 15:07:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97171c784ca345a9514892858eb1b26d804ab7a5
Cr-Commit-Position: refs/heads/master@{#315035}

Powered by Google App Engine
This is Rietveld 408576698