Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_interaction_record.py

Issue 904903002: Revert of [telemetry] Add a V8GCTimes measurement and benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py b/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
index 8b43909f04afc5c78814c0e9c11397c6fc99ab5a..8c1c8170317329a2e3f10587cd732138064d8e77 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_interaction_record.py
@@ -7,6 +7,8 @@
import telemetry.timeline.bounds as timeline_bounds
from telemetry import decorators
+# Enables the fast metric for this interaction
+IS_FAST = 'is_fast'
# Enables the responsiveness metric for this interaction
IS_RESPONSIVE = 'is_responsive'
# Enables the smoothness metric for this interaction
@@ -15,6 +17,7 @@
REPEATABLE = 'repeatable'
METRICS = [
+ IS_FAST,
IS_RESPONSIVE,
IS_SMOOTH
]
@@ -85,7 +88,7 @@
is currently done by pushing markers into the console.time/timeEnd API: this
for instance can be issued in JS:
- var str = 'Interaction.SendEmail/is_smooth,is_responsive';
+ var str = 'Interaction.SendEmail/is_smooth,is_responsive,is_fast';
console.time(str);
setTimeout(function() {
console.timeEnd(str);
@@ -93,10 +96,11 @@
When run with perf.measurements.timeline_based_measurement running, this will
then cause a TimelineInteractionRecord to be created for this range with
- smoothness and responsive metrics reported for the marked up 1000ms
+ smoothness, responsive, and fast metrics reported for the marked up 1000ms
time-range.
The valid interaction flags are:
+ * is_fast: Enables the fast metric
* is_responsive: Enables the responsiveness metric
* is_smooth: Enables the smoothness metric
* repeatable: Allows other interactions to use the same label
@@ -122,6 +126,10 @@
@property
def end(self):
return self._end
+
+ @property
+ def is_fast(self):
+ return IS_FAST in self._flags
@property
def is_responsive(self):
« no previous file with comments | « tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698