Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 904903002: Revert of [telemetry] Add a V8GCTimes measurement and benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/v8_gc_times.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 5cb10c7ebd9f5901df8b22f6c41f31e16bb4e262..cfecc2598b22142dfb983df28ab9c27aa5a37c3b 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -3,40 +3,20 @@
# found in the LICENSE file.
import page_sets
-from measurements import v8_gc_times
+from telemetry.web_perf import timeline_based_measurement
from telemetry import benchmark
@benchmark.Disabled('win') # crbug.com/416502
class V8GarbageCollectionCases(benchmark.Benchmark):
- """Measure V8 GC metrics on the garbage collection cases."""
- test = v8_gc_times.V8GCTimes
- page_set = page_sets.GarbageCollectionCasesPageSet
+ """Measure V8 metrics on the garbage collection cases."""
+ def CreateTimelineBasedMeasurementOptions(self):
+ # TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become
+ # available in the 'benchmark' category.
+ return timeline_based_measurement.Options(overhead_level='v8-overhead')
@classmethod
def Name(cls):
return 'v8.garbage_collection_cases'
-@benchmark.Disabled('win') # crbug.com/416502
-class V8Top25(benchmark.Benchmark):
- """Measures V8 GC metrics on the while scrolling down the top 25 web pages.
-
- http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
- test = v8_gc_times.V8GCTimes
- page_set = page_sets.Top25SmoothPageSet
-
- @classmethod
- def Name(cls):
- return 'v8.top_25_smooth'
-
-@benchmark.Enabled('android')
-class V8KeyMobileSites(benchmark.Benchmark):
- """Measures V8 GC metrics on the while scrolling down key mobile sites.
-
- http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
- test = v8_gc_times.V8GCTimes
- page_set = page_sets.KeyMobileSitesSmoothPageSet
-
- @classmethod
- def Name(cls):
- return 'v8.key_mobile_sites_smooth'
+ page_set = page_sets.GarbageCollectionCasesPageSet
« no previous file with comments | « no previous file | tools/perf/measurements/v8_gc_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698