Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 904583002: PNaCl sandboxed linker: Use new IRT interface instead of using SRPC directly (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-binutils.git@master
Target Ref:
refs/heads/pnacl/2.24/master
Visibility:
Public.

Description

PNaCl sandboxed linker: Use new IRT interface instead of using SRPC directly BUG=https://code.google.com/p/chromium/issues/detail?id=302078 TEST=NaCl's Scons-based sandboxed linker tests R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/nacl-binutils.git;a=commit;h=c14c68b3d5d1c53006ab7be466d696887db81037

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Use const #

Total comments: 2

Patch Set 4 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -46 lines) Patch
M gold/main.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M gold/nacl_file.cc View 1 2 3 9 chunks +21 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Seaborn
Depends on https://codereview.chromium.org/883393005/ I'll remove the SRPC references from the configure script in a follow-on ...
5 years, 10 months ago (2015-02-05 18:19:02 UTC) #2
jvoung (off chromium)
Cool -- LGTM https://codereview.chromium.org/904583002/diff/40001/gold/nacl_file.cc File gold/nacl_file.cc (right): https://codereview.chromium.org/904583002/diff/40001/gold/nacl_file.cc#newcode70 gold/nacl_file.cc:70: // Set up interfaces for IRT ...
5 years, 10 months ago (2015-02-05 19:11:25 UTC) #3
Mark Seaborn
https://codereview.chromium.org/904583002/diff/40001/gold/nacl_file.cc File gold/nacl_file.cc (right): https://codereview.chromium.org/904583002/diff/40001/gold/nacl_file.cc#newcode70 gold/nacl_file.cc:70: // Set up interfaces for IRT open_resource. On 2015/02/05 ...
5 years, 10 months ago (2015-02-05 23:19:45 UTC) #5
Mark Seaborn
5 years, 10 months ago (2015-02-06 03:22:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
c14c68b3d5d1c53006ab7be466d696887db81037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698