Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: gold/main.cc

Issue 904583002: PNaCl sandboxed linker: Use new IRT interface instead of using SRPC directly (Closed) Base URL: http://git.chromium.org/native_client/nacl-binutils.git@master
Patch Set: Update comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gold/nacl_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gold/main.cc
diff --git a/gold/main.cc b/gold/main.cc
index c5fa9cf8b341c54c4e1f30361a5ed42a0ce5e5b8..29304dc965e4ed4642eab68776048710442ff3b1 100644
--- a/gold/main.cc
+++ b/gold/main.cc
@@ -134,8 +134,9 @@ write_debug_script(std::string, const char*, const char*)
#endif // !defined(DEBUG)
// @LOCALMOD-SB-BEGIN
-// For the SRPC build, main() is defined in nacl_file.cc and runs the SRPC
-// main loop. gold_main() is called by the RPC handler.
+// For the in-browser sandboxed build, main() is defined in
+// nacl_file.cc and calls an IRT interface for handling the browser's
+// request. gold_main() is called by that request handler.
#if defined(__native_client__)
int
gold_main(int argc, char** argv)
@@ -158,7 +159,7 @@ main(int argc, char** argv)
program_name = argv[0];
// In libiberty; expands @filename to the args in "filename".
- // @LOCALMOD-SB: skip this in SRPC mode since the commandline we
+ // @LOCALMOD-SB: skip this in sandboxed mode since the commandline we
// build will likely not have @filename (and we can avoid hijacking
// the file open operation there).
#if !defined(__native_client__)
@@ -338,7 +339,8 @@ main(int argc, char** argv)
gold_error("treating warnings as errors");
// @LOCALMOD-SB-BEGIN
- // This function is called via SRPC - we do not want it to exit
+ // This function is called from an IPC request handler. We do not
+ // want it to exit.
#if defined(__native_client__)
return errors.error_count() > 0;
#else
« no previous file with comments | « no previous file | gold/nacl_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698