Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 902223002: Plugin Power Saver: Remove ASK (left C2P). Replace with DETECT. (Closed)

Created:
5 years, 10 months ago by tommycli
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
chromium-reviews, davidben+watch_chromium.org, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, gavinp+prer_chromium.org, jkarlin+watch_chromium.org, asvitkine+watch_chromium.org, markusheintz_, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Remove ASK (left C2P). Replace with DETECT. Patchset 1 is a straight revert of https://codereview.chromium.org/829113004. Subsequent patches are modifications to the revert. Previously, we replaced ASK with BLOCK. BUG=456248, 403800 Committed: https://crrev.com/54d9cc0c8fc905230aae59ccba4f7bc30c559aa9 Cr-Commit-Position: refs/heads/master@{#315629}

Patch Set 1 #

Patch Set 2 : migrate ask to detect instead of block. #

Patch Set 3 : remove unnecessary actions.xml change. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -161 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_menu_model.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 2 chunks +0 lines, -18 lines 0 comments Download
D chrome/renderer/resources/click_to_play_plugin.html View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +1 line, -3 lines 0 comments Download
D chrome/test/data/prerender/prerender_plugin_click_to_play.html View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
tommycli
thestig: PTAL, thanks! Patchset 1 is a straight revert of the old CL (which is ...
5 years, 10 months ago (2015-02-06 20:28:33 UTC) #2
Lei Zhang
I don't see any changes to actions.xml in patch set 3.
5 years, 10 months ago (2015-02-07 00:02:02 UTC) #3
tommycli
On 2015/02/07 00:02:02, Lei Zhang wrote: > I don't see any changes to actions.xml in ...
5 years, 10 months ago (2015-02-09 20:14:32 UTC) #4
Lei Zhang
lgtm I edited the commit msg a little.
5 years, 10 months ago (2015-02-10 03:20:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902223002/60001
5 years, 10 months ago (2015-02-10 17:54:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41737)
5 years, 10 months ago (2015-02-10 18:01:29 UTC) #9
tommycli
tsepez: ptal render_messages.h Enum is only used internally, and not as integer values, so should ...
5 years, 10 months ago (2015-02-10 18:38:30 UTC) #11
Tom Sepez
Messages LGTM
5 years, 10 months ago (2015-02-10 19:25:17 UTC) #12
tommycli
tsepez: Thanks!
5 years, 10 months ago (2015-02-10 19:28:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902223002/60001
5 years, 10 months ago (2015-02-10 19:28:55 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-10 20:32:44 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 20:33:08 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/54d9cc0c8fc905230aae59ccba4f7bc30c559aa9
Cr-Commit-Position: refs/heads/master@{#315629}

Powered by Google App Engine
This is Rietveld 408576698