Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 829113004: Plugin Power Saver: Add back 'Click to play' option as 4th for plugins. (Closed)

Created:
5 years, 11 months ago by tommycli
Modified:
5 years, 11 months ago
CC:
Lei Zhang, chromium-reviews, davidben+watch_chromium.org, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, gavinp+prer_chromium.org, stuartmorgan+watch_chromium.org, jkarlin+watch_chromium.org, asvitkine+watch_chromium.org, markusheintz_, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Add back 'Click to play' option as 4th for plugins. This is a partial revert of the following patches: https://codereview.chromium.org/796543002/ https://codereview.chromium.org/819183002/ BUG=443978, 403800 Committed: https://crrev.com/b0590224eda6183ecc592307301e9b79a8f084ed Cr-Commit-Position: refs/heads/master@{#310646}

Patch Set 1 #

Patch Set 2 : Fix prerender browser test #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -25 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +18 lines, -0 lines 0 comments Download
A chrome/renderer/resources/click_to_play_plugin.html View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +3 lines, -1 line 0 comments Download
A + chrome/test/data/prerender/prerender_plugin_click_to_play.html View 2 chunks +7 lines, -5 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
tommycli
pkasting: PTAL. Thanks! It's implemented as a partial revert of the two listed patches in ...
5 years, 11 months ago (2015-01-08 00:12:49 UTC) #2
Peter Kasting
LGTM!
5 years, 11 months ago (2015-01-08 00:33:01 UTC) #4
tommycli
thestig: PTAL. This is the four-option patch we want in our back pocket in case ...
5 years, 11 months ago (2015-01-08 00:40:27 UTC) #6
tommycli
tsepez: chrome/common/render_messages.h please, thanks! isherman: tools/metrics/actions/actions.xml please, thanks!
5 years, 11 months ago (2015-01-08 00:42:01 UTC) #8
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-08 01:55:20 UTC) #9
Tom Sepez
Messages LGTM
5 years, 11 months ago (2015-01-08 18:33:52 UTC) #10
Ilya Sherman
actions.xml lgtm
5 years, 11 months ago (2015-01-08 20:38:05 UTC) #11
Ilya Sherman
Actually, LGTM % the requests below: https://codereview.chromium.org/829113004/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/829113004/diff/20001/tools/metrics/actions/actions.xml#newcode10051 tools/metrics/actions/actions.xml:10051: <owner>Please list the ...
5 years, 11 months ago (2015-01-08 20:39:09 UTC) #12
tommycli
isherman: Done. Thanks for quick review! https://codereview.chromium.org/829113004/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/829113004/diff/20001/tools/metrics/actions/actions.xml#newcode10051 tools/metrics/actions/actions.xml:10051: <owner>Please list the ...
5 years, 11 months ago (2015-01-08 21:09:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829113004/40001
5 years, 11 months ago (2015-01-09 00:52:00 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 01:03:28 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 01:04:17 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b0590224eda6183ecc592307301e9b79a8f084ed
Cr-Commit-Position: refs/heads/master@{#310646}

Powered by Google App Engine
This is Rietveld 408576698