Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/browser/ui/website_settings/permission_menu_model.cc

Issue 902223002: Plugin Power Saver: Remove ASK (left C2P). Replace with DETECT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/permission_menu_model.h" 5 #include "chrome/browser/ui/website_settings/permission_menu_model.h"
6 6
7 #include "chrome/grit/generated_resources.h" 7 #include "chrome/grit/generated_resources.h"
8 #include "ui/base/l10n/l10n_util.h" 8 #include "ui/base/l10n/l10n_util.h"
9 9
10 PermissionMenuModel::PermissionMenuModel( 10 PermissionMenuModel::PermissionMenuModel(
11 const GURL& url, 11 const GURL& url,
12 const WebsiteSettingsUI::PermissionInfo& info, 12 const WebsiteSettingsUI::PermissionInfo& info,
13 const ChangeCallback& callback) 13 const ChangeCallback& callback)
14 : ui::SimpleMenuModel(this), permission_(info), callback_(callback) { 14 : ui::SimpleMenuModel(this), permission_(info), callback_(callback) {
15 DCHECK(!callback_.is_null()); 15 DCHECK(!callback_.is_null());
16 base::string16 label; 16 base::string16 label;
17 switch (permission_.default_setting) { 17 switch (permission_.default_setting) {
18 case CONTENT_SETTING_ALLOW: 18 case CONTENT_SETTING_ALLOW:
19 label = l10n_util::GetStringUTF16( 19 label = l10n_util::GetStringUTF16(
20 IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_ALLOW); 20 IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_ALLOW);
21 break; 21 break;
22 case CONTENT_SETTING_BLOCK: 22 case CONTENT_SETTING_BLOCK:
23 label = l10n_util::GetStringUTF16( 23 label = l10n_util::GetStringUTF16(
24 IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_BLOCK); 24 IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_BLOCK);
25 break; 25 break;
26 case CONTENT_SETTING_ASK: 26 case CONTENT_SETTING_ASK:
27 // For Plugins, ASK is obsolete. Show as BLOCK to reflect actual behavior. 27 // For Plugins, ASK is obsolete. Show as DETECT to reflect actual
28 // behavior.
28 label = l10n_util::GetStringUTF16( 29 label = l10n_util::GetStringUTF16(
29 permission_.type == CONTENT_SETTINGS_TYPE_PLUGINS 30 permission_.type == CONTENT_SETTINGS_TYPE_PLUGINS
30 ? IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_BLOCK 31 ? IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_DETECT_IMPORTANT_CONTENT
31 : IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_ASK); 32 : IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_ASK);
32 break; 33 break;
33 case CONTENT_SETTING_DETECT_IMPORTANT_CONTENT: 34 case CONTENT_SETTING_DETECT_IMPORTANT_CONTENT:
34 label = l10n_util::GetStringUTF16( 35 label = l10n_util::GetStringUTF16(
35 IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_DETECT_IMPORTANT_CONTENT); 36 IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_DETECT_IMPORTANT_CONTENT);
36 break; 37 break;
37 case CONTENT_SETTING_NUM_SETTINGS: 38 case CONTENT_SETTING_NUM_SETTINGS:
38 NOTREACHED(); 39 NOTREACHED();
39 default: 40 default:
40 break; 41 break;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 permission_.default_setting = CONTENT_SETTING_NUM_SETTINGS; 73 permission_.default_setting = CONTENT_SETTING_NUM_SETTINGS;
73 AddCheckItem(CONTENT_SETTING_ALLOW, 74 AddCheckItem(CONTENT_SETTING_ALLOW,
74 l10n_util::GetStringUTF16(IDS_PERMISSION_ALLOW)); 75 l10n_util::GetStringUTF16(IDS_PERMISSION_ALLOW));
75 AddCheckItem(CONTENT_SETTING_BLOCK, 76 AddCheckItem(CONTENT_SETTING_BLOCK,
76 l10n_util::GetStringUTF16(IDS_PERMISSION_DENY)); 77 l10n_util::GetStringUTF16(IDS_PERMISSION_DENY));
77 } 78 }
78 79
79 PermissionMenuModel::~PermissionMenuModel() {} 80 PermissionMenuModel::~PermissionMenuModel() {}
80 81
81 bool PermissionMenuModel::IsCommandIdChecked(int command_id) const { 82 bool PermissionMenuModel::IsCommandIdChecked(int command_id) const {
82 // For Plugins, ASK is obsolete. Show as BLOCK to reflect actual behavior. 83 // For Plugins, ASK is obsolete. Show as DETECT to reflect actual behavior.
83 if (permission_.type == CONTENT_SETTINGS_TYPE_PLUGINS && 84 if (permission_.type == CONTENT_SETTINGS_TYPE_PLUGINS &&
84 permission_.setting == CONTENT_SETTING_ASK && 85 permission_.setting == CONTENT_SETTING_ASK &&
85 command_id == CONTENT_SETTING_BLOCK) { 86 command_id == CONTENT_SETTING_DETECT_IMPORTANT_CONTENT) {
86 return true; 87 return true;
87 } 88 }
88 return permission_.setting == command_id; 89 return permission_.setting == command_id;
89 } 90 }
90 91
91 bool PermissionMenuModel::IsCommandIdEnabled(int command_id) const { 92 bool PermissionMenuModel::IsCommandIdEnabled(int command_id) const {
92 return true; 93 return true;
93 } 94 }
94 95
95 bool PermissionMenuModel::GetAcceleratorForCommandId( 96 bool PermissionMenuModel::GetAcceleratorForCommandId(
96 int command_id, 97 int command_id,
97 ui::Accelerator* accelerator) { 98 ui::Accelerator* accelerator) {
98 // Accelerators are not supported. 99 // Accelerators are not supported.
99 return false; 100 return false;
100 } 101 }
101 102
102 void PermissionMenuModel::ExecuteCommand(int command_id, int event_flags) { 103 void PermissionMenuModel::ExecuteCommand(int command_id, int event_flags) {
103 permission_.setting = static_cast<ContentSetting>(command_id); 104 permission_.setting = static_cast<ContentSetting>(command_id);
104 callback_.Run(permission_); 105 callback_.Run(permission_);
105 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698