Adding instrumentation to locate the source of jankiness.

Adding instrumentation to locate the source of jankiness.

Mechanical change that adds instrumentation required to locate the source of
jankiness (i.e. a long-running fragment of code executed as a part of the task
that causes jank) in the code. See the bug for details on what kind of jank we
are after.  A number of similar CLs were landed, and none of them caused issues.
The code of the instrumentation is highly optimized and is not expected to
affect performance. The code simply creates a diagnostic task which is identical
to ones created by PostTask or IPC message handlers.

This also updates the existing instrumentation for bug 418183 to include the bug
number everywhere.

BUG=418183, 455423, 455434, 455469
TEST=none
R=vadimt@chromium.org
TBR=jochen, mmenke, rockot, thestig

Committed: https://chromium.googlesource.com/chromium/src/+/650180680cc05b5771628d502bc6803a1d8997ad

[Peter Kasting, 2015-02-05 01:11:10]

pkasting@chromium.org changed reviewers:
+ vadimt@chromium.org

[vadimt, 2015-02-05 01:17:14]

https://codereview.chromium.org/901773002/diff/1/net/socket/tcp_socket_win.cc
File net/socket/tcp_socket_win.cc (right):

https://codereview.chromium.org/901773002/diff/1/net/socket/tcp_socket_win.cc...
net/socket/tcp_socket_win.cc:980: "418183 TCPSocketWin::DidCompleteConnect2"));
The instrumentation will interfere with WSAGetLastError, which will return 0.
This is because it makes an OS call to get time.

https://codereview.chromium.org/901773002/diff/1/net/socket/tcp_socket_win.cc...
net/socket/tcp_socket_win.cc:1067: FROM_HERE_WITH_EXPLICIT_FUNCTION(
Same thing

[Peter Kasting, 2015-02-05 01:59:38]

PTAL.

https://codereview.chromium.org/901773002/diff/1/net/socket/tcp_socket_win.cc
File net/socket/tcp_socket_win.cc (right):

https://codereview.chromium.org/901773002/diff/1/net/socket/tcp_socket_win.cc...
net/socket/tcp_socket_win.cc:980: "418183 TCPSocketWin::DidCompleteConnect2"));
On 2015/02/05 01:17:14, vadimt wrote:
> The instrumentation will interfere with WSAGetLastError, which will return 0.
> This is because it makes an OS call to get time.

Done.

https://codereview.chromium.org/901773002/diff/1/net/socket/tcp_socket_win.cc...
net/socket/tcp_socket_win.cc:1067: FROM_HERE_WITH_EXPLICIT_FUNCTION(
On 2015/02/05 01:17:14, vadimt wrote:
> Same thing

Done.

[vadimt, 2015-02-05 02:03:43]

lgtm

[Peter Kasting, 2015-02-05 21:36:30]

pkasting@chromium.org changed reviewers:
+ jochen@chromium.org, mmenke@chromium.org, rockot@chromium.org,
thestig@chromium.org

[Peter Kasting, 2015-02-05 21:37:21]

TBRing for mechanical change:
thestig: base/, chrome/ OWNERS
jochen: components/, content/ OWNERS
rockot: device/ OWNERS
mmenke: net/ OWNERS

[commit-bot: I haz the power, 2015-02-05 21:46:03]

Patchset 2 (id:??) landed as
https://crrev.com/650180680cc05b5771628d502bc6803a1d8997ad
Cr-Commit-Position: refs/heads/master@{#314885}

[Peter Kasting, 2015-02-05 21:46:17]

Committed patchset #2 (id:20001) manually as
650180680cc05b5771628d502bc6803a1d8997ad (presubmit successful).

[Lei Zhang, 2015-02-05 21:47:43]

lgtm