content/child/web_url_loader_impl.cc - Issue 901773002: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_url_loader_impl.cc

Issue 901773002: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile + remove some tracking Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/web_url_loader_impl.cc

diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc

index 1f852bdc03385c5917f7e853707b637c9db4d2a4..adca0daa2168438986daa602ed441b8934def803 100644

--- a/content/child/web_url_loader_impl.cc

+++ b/content/child/web_url_loader_impl.cc

@@ -14,6 +14,7 @@

#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/memory/scoped_ptr.h"

+#include "base/profiler/scoped_tracker.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string_util.h"

#include "base/time/time.h"

@@ -896,6 +897,11 @@ MojoResult WebURLLoaderImpl::Context::WriteDataOnBodyStream(const char* data,

}

void WebURLLoaderImpl::Context::OnHandleGotWritable(MojoResult result) {

+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455434 is

+ // fixed.

+ tracked_objects::ScopedTracker tracking_profile(

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "455434 WebURLLoaderImpl::Context::OnHandleGotWritable"));

if (result != MOJO_RESULT_OK) {

if (client_) {

client_->didFail(loader_,

« no previous file with comments | « content/child/web_data_consumer_handle_impl.cc ('k') | device/hid/hid_connection_win.cc » ('j') | no next file with comments »