Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 901773002: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile + remove some tracking Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/synchronization/waitable_event_watcher_win.cc ('k') | chrome/common/service_process_util_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc
index 358cfa2cd88d3196302dd707046bafb61c15b277..04690dc933e2dd9fb6bb2bb12f2158fdc23c2bcf 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc
@@ -15,6 +15,7 @@
#include "base/path_service.h"
#include "base/prefs/pref_change_registrar.h"
#include "base/prefs/pref_service.h"
+#include "base/profiler/scoped_tracker.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/threading/thread.h"
@@ -462,18 +463,34 @@ void SafeBrowsingService::StartOnIOThread(
return;
enabled_ = true;
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455469 is fixed.
+ tracked_objects::ScopedTracker tracking_profile1(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "455469 SafeBrowsingService::GetProtocolConfig"));
SafeBrowsingProtocolConfig config = GetProtocolConfig();
#if defined(FULL_SAFE_BROWSING)
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455469 is fixed.
+ tracked_objects::ScopedTracker tracking_profile2(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "455469 SafeBrowsingDatabaseManager::StartOnIOThread"));
DCHECK(database_manager_.get());
database_manager_->StartOnIOThread();
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455469 is fixed.
+ tracked_objects::ScopedTracker tracking_profile3(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "455469 SafeBrowsingProtocolManager::Create"));
DCHECK(!protocol_manager_);
protocol_manager_ = SafeBrowsingProtocolManager::Create(
database_manager_.get(), url_request_context_getter, config);
protocol_manager_->Initialize();
#endif
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455469 is fixed.
+ tracked_objects::ScopedTracker tracking_profile4(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "455469 SafeBrowsingPingManager::Create"));
DCHECK(!ping_manager_);
ping_manager_ = SafeBrowsingPingManager::Create(
url_request_context_getter, config);
« no previous file with comments | « base/synchronization/waitable_event_watcher_win.cc ('k') | chrome/common/service_process_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698