Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 901563003: Experimenting delaying scroll start on wikipedia page in key_mobile_sites_smooth (Closed)

Created:
5 years, 10 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Experimenting delaying scroll start on wikipedia page in key_mobile_sites_smooth Currently smoothness action (e.g. scrolling) starts when the document.readyState = interactive or complete. It is noticed that when the readyState = interactive, the page can still be loading resources so there would be contention on the main thread between resources loading and input handling, which could have impact on the smoothness metrics. It is to our interests in actually solving the contention issues so we don't want to artificially delay the action start just to avoid the contention. But I do see the benefit in running an experiment on just wikipedia with delayed action start so as to understand to which degree this contention is affecting our metrics. So this CL makes a duplicate of the Wikipedia page in the key_mobile_sites_smooth and running that particular page with starting scrolling on readyState = complete. BUG=455277 Committed: https://crrev.com/0d9d1bc419bbeabe0a6a6767cba9254441712da3 Cr-Commit-Position: refs/heads/master@{#314932}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M tools/perf/page_sets/key_mobile_sites_smooth.py View 2 chunks +13 lines, -2 lines 2 comments Download

Messages

Total messages: 17 (5 generated)
Yufeng Shen (Slow to review)
5 years, 10 months ago (2015-02-05 21:46:42 UTC) #2
nednguyen
LGTM if key_mobile_sites_smooth's owners are happy
5 years, 10 months ago (2015-02-05 21:49:17 UTC) #4
jdduke (slow)
On 2015/02/05 21:49:17, nednguyen wrote: > LGTM if key_mobile_sites_smooth's owners are happy lgtm
5 years, 10 months ago (2015-02-05 21:51:17 UTC) #5
jdduke (slow)
https://codereview.chromium.org/901563003/diff/1/tools/perf/page_sets/key_mobile_sites_smooth.py File tools/perf/page_sets/key_mobile_sites_smooth.py (right): https://codereview.chromium.org/901563003/diff/1/tools/perf/page_sets/key_mobile_sites_smooth.py#newcode178 tools/perf/page_sets/key_mobile_sites_smooth.py:178: name='Wikipedia (1 tab)')) What is this "1 tab" modifier ...
5 years, 10 months ago (2015-02-05 21:51:30 UTC) #7
Yufeng Shen (Slow to review)
https://codereview.chromium.org/901563003/diff/1/tools/perf/page_sets/key_mobile_sites_smooth.py File tools/perf/page_sets/key_mobile_sites_smooth.py (right): https://codereview.chromium.org/901563003/diff/1/tools/perf/page_sets/key_mobile_sites_smooth.py#newcode178 tools/perf/page_sets/key_mobile_sites_smooth.py:178: name='Wikipedia (1 tab)')) On 2015/02/05 21:51:29, jdduke wrote: > ...
5 years, 10 months ago (2015-02-05 21:52:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901563003/1
5 years, 10 months ago (2015-02-05 21:53:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/52653)
5 years, 10 months ago (2015-02-05 23:58:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901563003/1
5 years, 10 months ago (2015-02-06 00:05:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 01:04:23 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d9d1bc419bbeabe0a6a6767cba9254441712da3 Cr-Commit-Position: refs/heads/master@{#314932}
5 years, 10 months ago (2015-02-06 01:05:50 UTC) #15
nduca
Drive by: this is a really great goal to chase further... we should aspire to ...
5 years, 10 months ago (2015-02-10 18:27:25 UTC) #16
chromium-reviews
5 years, 10 months ago (2015-02-10 19:05:12 UTC) #17
Message was sent while issue was closed.
On Tue, Feb 10, 2015 at 1:27 PM, <nduca@chromium.org> wrote:

> Drive by: this is a really great goal to chase further... we should aspire
> to
> having monitoring of more (all?) of our pages in both earlyscroll and
> afterload-scroll modes. Anecdotally, people scroll the second we do our
> first
> paint.
>
>
Yeah, I was thinking of making a dup of the whole
sync_scroll.key_mobile_sites_smooth
that runs afterload-scroll as reference. The wikipedia page in this CL is
used as
a pilot to verify our conjecture that the noisy perf metrics results are
indeed due to
the timing of scroll start.


> Editorially: is there a difference in practice between first paint, the
> first
> time raf fires, and complete state?
>
>
I wouldn't trust first paint and first raf. They are more browser
implementation dependent.
And in practice I can see many frames pushed out during web content loading
(without any
user interaction). While complete/interactive state is at least web
standard backed up.


> https://codereview.chromium.org/901563003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698