Experimenting delaying scroll start on wikipedia page in key_mobile_sites_smooth

tools/perf/page_sets/key_mobile_sites_smooth.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from telemetry.page import page as page_module
 from telemetry.page import page_set as page_set_module
 
 from page_sets import key_mobile_sites_pages
 
 
 def _IssueMarkerAndScroll(action_runner):
   interaction = action_runner.BeginGestureInteraction(
       'ScrollAction', is_smooth=True)
   action_runner.ScrollPage()
   interaction.End()
 
 
 def _CreatePageClassWithSmoothInteractions(page_cls):
   class DerivedSmoothPage(page_cls):  # pylint: disable=W0232
 
     def RunPageInteractions(self, action_runner):
       _IssueMarkerAndScroll(action_runner)
   return DerivedSmoothPage
 
 
 class KeyMobileSitesSmoothPage(page_module.Page):
 
-  def __init__(self, url, page_set, name='', labels=None):
+  def __init__(self, url, page_set, name='', labels=None,
+               action_on_load_complete=False):
     super(KeyMobileSitesSmoothPage, self).__init__(
         url=url, page_set=page_set, name=name,
         credentials_path='data/credentials.json', labels=labels)
     self.user_agent_type = 'mobile'
     self.archive_data_file = 'data/key_mobile_sites.json'
+    self.action_on_load_complete = action_on_load_complete
 
   def RunPageInteractions(self, action_runner):
+    if self.action_on_load_complete:
+        action_runner.WaitForJavaScriptCondition(
+            'document.readyState == "complete"', 30)
     _IssueMarkerAndScroll(action_runner)
 
 
 class GmailSmoothPage(key_mobile_sites_pages.GmailPage):
 
   def RunPageInteractions(self, action_runner):
     interaction = action_runner.BeginGestureInteraction(
         'ScrollAction', is_smooth=True)
     action_runner.ScrollElement(element_function=(
         'document.getElementById("views").childNodes[1].firstChild'))
@@ skipping 114 matching lines @@
       url='http://googlewebmastercentral.blogspot.com/',
       page_set=self, name='Blogger'))
 
     # Why: #18 (Alexa global), Picked an interesting post """
     self.AddUserStory(KeyMobileSitesSmoothPage(
       # pylint: disable=line-too-long
       url='http://en.blog.wordpress.com/2012/09/04/freshly-pressed-editors-picks-for-august-2012/',
       page_set=self,
       name='Wordpress'))
 
-   # Why: #6 (Alexa) most visited worldwide, picked an interesting page
+    # Why: #6 (Alexa) most visited worldwide, picked an interesting page
     self.AddUserStory(KeyMobileSitesSmoothPage(
       url='http://en.wikipedia.org/wiki/Wikipedia',
       page_set=self,
       name='Wikipedia (1 tab)'))

[jdduke (slow), 2015/02/05 21:51:29]

What is this "1 tab" modifier all about?

[Yufeng Shen (Slow to review), 2015/02/05 21:52:43]

no idea, I guess just some historical naming.

 
+    # Why: Wikipedia page with a delayed scroll start
+    self.AddUserStory(KeyMobileSitesSmoothPage(
+      url='http://en.wikipedia.org/wiki/Wikipedia',
+      page_set=self,
+      name='Wikipedia (1 tab) - delayed scroll start',
+      action_on_load_complete=True))
 
     # Why: #8 (Alexa global), picked an interesting page
     # Forbidden (Rate Limit Exceeded)
     # self.AddUserStory(KeyMobileSitesSmoothPage(
     #  url='http://twitter.com/katyperry', page_set=self, name='Twitter'))
 
     # Why: #37 (Alexa global) """
     self.AddUserStory(KeyMobileSitesSmoothPage(
         url='http://pinterest.com',
         page_set=self,
@@ skipping 67 matching lines @@
       ('http://www.baidu.com/s?wd=barack+obama&rsv_bp=0&rsv_spt=3&rsv_sug3=9&'
        'rsv_sug=0&rsv_sug4=3824&rsv_sug1=3&inputT=4920'),
       # Why: Top search engine
       'http://www.bing.com/search?q=sloths',
       # Why: Good example of poor initial scrolling
       'http://ftw.usatoday.com/2014/05/spelling-bee-rules-shenanigans'
     ]
 
     for url in urls_list:
       self.AddUserStory(KeyMobileSitesSmoothPage(url, self))