Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: tools/perf/page_sets/key_mobile_sites_smooth.py

Issue 901563003: Experimenting delaying scroll start on wikipedia page in key_mobile_sites_smooth (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_mobile_sites_smooth.py
diff --git a/tools/perf/page_sets/key_mobile_sites_smooth.py b/tools/perf/page_sets/key_mobile_sites_smooth.py
index 36178c5f462a07b5c8326a7bd795f7e360c2672f..18d12259c2c4c7b480a1f7978e6f73ebd083110a 100644
--- a/tools/perf/page_sets/key_mobile_sites_smooth.py
+++ b/tools/perf/page_sets/key_mobile_sites_smooth.py
@@ -24,14 +24,19 @@ def _CreatePageClassWithSmoothInteractions(page_cls):
class KeyMobileSitesSmoothPage(page_module.Page):
- def __init__(self, url, page_set, name='', labels=None):
+ def __init__(self, url, page_set, name='', labels=None,
+ action_on_load_complete=False):
super(KeyMobileSitesSmoothPage, self).__init__(
url=url, page_set=page_set, name=name,
credentials_path='data/credentials.json', labels=labels)
self.user_agent_type = 'mobile'
self.archive_data_file = 'data/key_mobile_sites.json'
+ self.action_on_load_complete = action_on_load_complete
def RunPageInteractions(self, action_runner):
+ if self.action_on_load_complete:
+ action_runner.WaitForJavaScriptCondition(
+ 'document.readyState == "complete"', 30)
_IssueMarkerAndScroll(action_runner)
@@ -166,12 +171,18 @@ class KeyMobileSitesSmoothPageSet(page_set_module.PageSet):
page_set=self,
name='Wordpress'))
- # Why: #6 (Alexa) most visited worldwide, picked an interesting page
+ # Why: #6 (Alexa) most visited worldwide, picked an interesting page
self.AddUserStory(KeyMobileSitesSmoothPage(
url='http://en.wikipedia.org/wiki/Wikipedia',
page_set=self,
name='Wikipedia (1 tab)'))
jdduke (slow) 2015/02/05 21:51:29 What is this "1 tab" modifier all about?
Yufeng Shen (Slow to review) 2015/02/05 21:52:43 no idea, I guess just some historical naming.
+ # Why: Wikipedia page with a delayed scroll start
+ self.AddUserStory(KeyMobileSitesSmoothPage(
+ url='http://en.wikipedia.org/wiki/Wikipedia',
+ page_set=self,
+ name='Wikipedia (1 tab) - delayed scroll start',
+ action_on_load_complete=True))
# Why: #8 (Alexa global), picked an interesting page
# Forbidden (Rate Limit Exceeded)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698