Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 900743003: Unify expand and collapse icons. (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify expand and collapse icons. - Switch to using expand and collapse icons from internal repo - Start using TintedDrawable for WebsitePreferences. BUG=454859 Committed: https://crrev.com/50b79dc68bf5a4bb3f905533d78457c4f2d25153 Cr-Commit-Position: refs/heads/master@{#314686}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unused method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
A chrome/android/java/res/drawable-hdpi/ic_collapse.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_expand_less.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_expand_more.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_collapse.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_expand_less.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_expand_more.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_collapse.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_expand_less.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_expand_more.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_collapse.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_expand_less.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_expand_more.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_collapse.png View Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/ic_expand.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_expand_less.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_expand_more.png View Binary file 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
aurimas (slooooooooow)
newt: PTAL
5 years, 10 months ago (2015-02-04 02:49:34 UTC) #2
newt (away)
lgtm after comment https://chromiumcodereview.appspot.com/900743003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java (right): https://chromiumcodereview.appspot.com/900743003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java#newcode67 chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java:67: public void setIcon(int resourceId) { this ...
5 years, 10 months ago (2015-02-04 21:25:08 UTC) #3
newt (away)
Also, let's rename the images to ic_down/up_arrow.png since they're used for things besides expanding and ...
5 years, 10 months ago (2015-02-04 21:26:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900743003/20001
5 years, 10 months ago (2015-02-05 00:17:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 00:48:25 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:51:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50b79dc68bf5a4bb3f905533d78457c4f2d25153
Cr-Commit-Position: refs/heads/master@{#314686}

Powered by Google App Engine
This is Rietveld 408576698