Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3986)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java

Issue 900743003: Unify expand and collapse icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused method Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java
index 53be86bd2daee987c9013fd01cf08fea89c506b9..1682e8d9454f450bd97bf944c5330bd0e971962b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java
@@ -31,6 +31,7 @@ import org.chromium.chrome.browser.preferences.LocationSettings;
import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate;
import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
+import org.chromium.chrome.browser.widget.TintedDrawable;
import org.chromium.ui.text.SpanApplier;
import org.chromium.ui.text.SpanApplier.SpanInfo;
@@ -437,8 +438,9 @@ public class WebsitePreferences extends PreferenceFragment
// Set the title and arrow icons for the header.
allowedGroup.setGroupTitle(resourceId, numAllowed);
- allowedGroup.setIcon(
- mAllowListExpanded ? R.drawable.ic_expand_less : R.drawable.ic_expand_more);
+ TintedDrawable icon = TintedDrawable.constructTintedDrawable(getResources(),
+ mAllowListExpanded ? R.drawable.ic_expand : R.drawable.ic_collapse);
+ allowedGroup.setIcon(icon);
}
private void updateBlockedHeader(int numBlocked) {
@@ -452,19 +454,22 @@ public class WebsitePreferences extends PreferenceFragment
// Set the title and arrow icons for the header.
blockedGroup.setGroupTitle(R.string.website_settings_blocked_group_heading, numBlocked);
- blockedGroup.setIcon(
- mBlockListExpanded ? R.drawable.ic_expand_less : R.drawable.ic_expand_more);
+ TintedDrawable icon = TintedDrawable.constructTintedDrawable(getResources(),
+ mBlockListExpanded ? R.drawable.ic_expand : R.drawable.ic_collapse);
+ blockedGroup.setIcon(icon);
}
private Website createSiteByOrigin(WebsiteAddress address) {
String origin = address.getOrigin();
String host = address.getHost();
Website site = new Website(address);
- if (!mSitesByOrigin.containsKey(origin))
+ if (!mSitesByOrigin.containsKey(origin)) {
mSitesByOrigin.put(origin, new HashSet<Website>());
+ }
mSitesByOrigin.get(origin).add(site);
- if (!mSitesByHost.containsKey(host))
+ if (!mSitesByHost.containsKey(host)) {
mSitesByHost.put(host, new HashSet<Website>());
+ }
mSitesByHost.get(host).add(site);
return site;
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698