chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java - Issue 900743003: Unify expand and collapse icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

Issue 900743003: Unify expand and collapse icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused method Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/ic_expand_more.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

index 3394df1561352d3869ad7df2009d69f23f5656e6..772aea5a9fa958255acdc16167c26514d4365115 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java

@@ -64,8 +64,8 @@ public class ExpandablePreferenceGroup extends PreferenceGroup {

}

@Override

- public void setIcon(int resourceId) {

- mDrawable = getContext().getResources().getDrawable(resourceId);

+ public void setIcon(Drawable drawable) {

+ mDrawable = drawable;

if (mImageView != null) mImageView.setImageDrawable(mDrawable);

}