Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 900683004: Removed unused code in skia/ext/vector_*. (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused code in skia/ext/vector_*. Code is not used after we Chrome stopped generation of EMF inside render. Committed: https://crrev.com/a73fc377cdadc6a183cdc453b7d49dfbdaf9d1da Cr-Commit-Position: refs/heads/master@{#315076}

Patch Set 1 #

Patch Set 2 : Tue Feb 3 19:16:58 PST 2015 #

Patch Set 3 : Tue Feb 3 23:01:55 PST 2015 #

Patch Set 4 : Tue Feb 3 23:09:45 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2150 lines) Patch
M components/printing/renderer/print_web_view_helper_linux.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_mac.mm View 2 chunks +1 line, -2 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_pdf_win.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M printing/emf_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 2 chunks +1 line, -2 lines 0 comments Download
M skia/BUILD.gn View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
D skia/ext/vector_canvas.h View 1 chunk +0 lines, -22 lines 0 comments Download
D skia/ext/vector_canvas_unittest.cc View 1 chunk +0 lines, -970 lines 0 comments Download
D skia/ext/vector_platform_device_emf_win.h View 1 chunk +0 lines, -141 lines 0 comments Download
D skia/ext/vector_platform_device_emf_win.cc View 1 chunk +0 lines, -982 lines 0 comments Download
M skia/skia_chrome.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M skia/skia_tests.gyp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-04 07:06:20 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2015/02/04 07:06:20, Vitaly Buka wrote: ping
5 years, 10 months ago (2015-02-05 22:33:44 UTC) #3
reed1
woot! lgtm
5 years, 10 months ago (2015-02-06 15:28:51 UTC) #5
Vitaly Buka (NO REVIEWS)
+nasko@ or creis@ of content/
5 years, 10 months ago (2015-02-06 18:10:25 UTC) #7
Charlie Reis
Hooray for dead code removal! content/LGTM.
5 years, 10 months ago (2015-02-06 18:15:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900683004/60001
5 years, 10 months ago (2015-02-06 18:37:30 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-06 18:40:44 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:41:12 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a73fc377cdadc6a183cdc453b7d49dfbdaf9d1da
Cr-Commit-Position: refs/heads/master@{#315076}

Powered by Google App Engine
This is Rietveld 408576698