Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 900433003: Add Mojo interfaces for out-of-process proxy resolver. (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Mojo interfaces for out-of-process proxy resolver. See: https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit# BUG=11746 Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561 Cr-Commit-Position: refs/heads/master@{#314509}

Patch Set 1 #

Total comments: 20

Patch Set 2 : Review comments. #

Total comments: 11

Patch Set 3 : More review comments. #

Patch Set 4 : Remove LoadState enum. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -7 lines) Patch
A + net/interfaces/BUILD.gn View 1 chunk +5 lines, -7 lines 0 comments Download
A net/interfaces/host_resolver_service.mojom View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A net/interfaces/proxy_resolver_service.mojom View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Anand Mistry (off Chromium)
You might be wondering why I'm sending this out even though nothing depends on it. ...
5 years, 10 months ago (2015-02-03 02:31:18 UTC) #2
eroman
https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom File net/interfaces/host_resolver_service.mojom (right): https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom#newcode19 net/interfaces/host_resolver_service.mojom:19: ADDRESS_FAMILY_IPV6, I doubt this is actually going to be ...
5 years, 10 months ago (2015-02-03 04:53:29 UTC) #3
Anand Mistry (off Chromium)
https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom File net/interfaces/host_resolver_service.mojom (right): https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom#newcode19 net/interfaces/host_resolver_service.mojom:19: ADDRESS_FAMILY_IPV6, On 2015/02/03 04:53:29, eroman wrote: > I doubt ...
5 years, 10 months ago (2015-02-03 06:27:22 UTC) #4
Sam McNally
https://codereview.chromium.org/900433003/diff/1/net/interfaces/proxy_resolver_service.mojom File net/interfaces/proxy_resolver_service.mojom (right): https://codereview.chromium.org/900433003/diff/1/net/interfaces/proxy_resolver_service.mojom#newcode31 net/interfaces/proxy_resolver_service.mojom:31: UpdateLoadState(LoadState load_state); On 2015/02/03 06:27:22, Anand Mistry wrote: > ...
5 years, 10 months ago (2015-02-03 23:51:30 UTC) #5
eroman
https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom File net/interfaces/host_resolver_service.mojom (right): https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom#newcode41 net/interfaces/host_resolver_service.mojom:41: string canonical_name; On 2015/02/03 06:27:22, Anand Mistry wrote: > ...
5 years, 10 months ago (2015-02-04 01:25:20 UTC) #6
Anand Mistry (off Chromium)
https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom File net/interfaces/host_resolver_service.mojom (right): https://codereview.chromium.org/900433003/diff/1/net/interfaces/host_resolver_service.mojom#newcode41 net/interfaces/host_resolver_service.mojom:41: string canonical_name; On 2015/02/04 01:25:19, eroman wrote: > On ...
5 years, 10 months ago (2015-02-04 04:05:31 UTC) #8
Sam McNally
lgtm
5 years, 10 months ago (2015-02-04 04:27:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/900433003/60001
5 years, 10 months ago (2015-02-04 04:48:06 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-04 05:53:16 UTC) #13
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561 Cr-Commit-Position: refs/heads/master@{#314509}
5 years, 10 months ago (2015-02-04 05:56:16 UTC) #14
Noel Gordon
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575 Broke device_unittests device_unittests SerialConnectionTest.Cancel
5 years, 10 months ago (2015-02-04 07:36:43 UTC) #15
Noel Gordon
5 years, 10 months ago (2015-02-04 07:37:05 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/892373006/ by noel@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems.
.

Powered by Google App Engine
This is Rietveld 408576698