Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 892373006: Revert of Add Mojo interfaces for out-of-process proxy resolver. (Closed)

Created:
5 years, 10 months ago by Noel Gordon
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Mojo interfaces for out-of-process proxy resolver. (patchset #4 id:60001 of https://codereview.chromium.org/900433003/) Reason for revert: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38575 Broke device_unittests device_unittests SerialConnectionTest.Cancel it seems. Original issue's description: > Add Mojo interfaces for out-of-process proxy resolver. > > See: > https://docs.google.com/a/chromium.org/document/d/1n5hr4KJhZl2A4MicTfmyiHPdiKp7kmUoWXnRBN8SrZE/edit# > > BUG=11746 > > Committed: https://crrev.com/073e42bb7587b90594e5799fb6a4afe08a1e1561 > Cr-Commit-Position: refs/heads/master@{#314509} TBR=rdsmith@chromium.org,eroman@chromium.org,sammc@chromium.org,amistry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=11746 Committed: https://crrev.com/7d4ec1aa24e79406d29e0cafbb531a3fabfe815f Cr-Commit-Position: refs/heads/master@{#314519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -131 lines) Patch
D net/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D net/interfaces/host_resolver_service.mojom View 1 chunk +0 lines, -55 lines 0 comments Download
D net/interfaces/proxy_resolver_service.mojom View 1 chunk +0 lines, -48 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Noel Gordon
Created Revert of Add Mojo interfaces for out-of-process proxy resolver.
5 years, 10 months ago (2015-02-04 07:37:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892373006/1
5 years, 10 months ago (2015-02-04 07:37:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 07:38:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d4ec1aa24e79406d29e0cafbb531a3fabfe815f Cr-Commit-Position: refs/heads/master@{#314519}
5 years, 10 months ago (2015-02-04 07:39:41 UTC) #4
Anand Mistry (off Chromium)
On 2015/02/04 07:39:41, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-02-04 07:40:00 UTC) #5
Anand Mistry (off Chromium)
On 2015/02/04 07:40:00, Anand Mistry wrote: > On 2015/02/04 07:39:41, I haz the power (commit-bot) ...
5 years, 10 months ago (2015-02-04 07:43:35 UTC) #6
Noel Gordon
On 2015/02/04 07:43:35, Anand Mistry wrote: > On 2015/02/04 07:40:00, Anand Mistry wrote: > > ...
5 years, 10 months ago (2015-02-04 07:56:41 UTC) #7
Anand Mistry (off Chromium)
5 years, 10 months ago (2015-02-04 08:37:49 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/882173005/ by amistry@chromium.org.

The reason for reverting is: The code in this change is not linked into any
binary.

Test is flaky:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

The likely cause of the test failure is
https://chromium.googlesource.com/chromium/src/+/bc78a2320b50eba4fe397f1f838a....
The author has been informed and the test will be fixed soon.
.

Powered by Google App Engine
This is Rietveld 408576698