Remove the obsolete OverwriteMode optimization.

Remove the obsolete OverwriteMode optimization.

R=jkummerow@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/634b0f20f4bbdad305c87fd8e196f4c05efbde1f

[Benedikt Meurer, 2015-02-05 09:53:48]

bmeurer@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Benedikt Meurer, 2015-02-05 09:53:48]

PTAL

[Jakob Kummerow, 2015-02-05 10:21:57]

Love it, but I'd be a little more careful with removing pre-generated stubs (see
below).

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc
File src/ic/ic-state.cc (left):

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:124: GENERATE(Token::ADD, SMI, SMI, INT32, OVERWRITE_LEFT);
I would assume that we want to keep the SMI,SMI,INT32 and SMI,SMI,SMI variants
(just without any OVERWRITE flag).

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:136: GENERATE(Token::BIT_AND, NUMBER, INT32, INT32,
OVERWRITE_RIGHT);
keep this?

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:140: GENERATE(Token::BIT_AND, SMI, INT32, SMI,
OVERWRITE_RIGHT);
keep this?

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:141: GENERATE(Token::BIT_AND, SMI, NUMBER, SMI,
OVERWRITE_RIGHT);
keep this?

Ah, you know what, instead of manually comparing all these lines, let me suggest
the following algorithm to be applied to the old code:

1.) s/, NO_OVERWRITE//, s/, OVERWRITE_LEFT//, s/, OVERWRITE_RIGHT//
2.) sort | uniq

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.h
File src/ic/ic-state.h (right):

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.h#newcod...
src/ic/ic-state.h:144: class ResultKindField : public BitField<Kind, 6, 3> {};
Please either insert a comment that bits 4 and 5 are unused, or shift up the
remaining BitFields to close the gap.

[Benedikt Meurer, 2015-02-05 10:32:30]

Thanks. Comments addressed.

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc
File src/ic/ic-state.cc (left):

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:124: GENERATE(Token::ADD, SMI, SMI, INT32, OVERWRITE_LEFT);
On 2015/02/05 10:21:57, Jakob wrote:
> I would assume that we want to keep the SMI,SMI,INT32 and SMI,SMI,SMI variants
> (just without any OVERWRITE flag).

Done.

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:136: GENERATE(Token::BIT_AND, NUMBER, INT32, INT32,
OVERWRITE_RIGHT);
On 2015/02/05 10:21:57, Jakob wrote:
> keep this?

Done.

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:140: GENERATE(Token::BIT_AND, SMI, INT32, SMI,
OVERWRITE_RIGHT);
On 2015/02/05 10:21:57, Jakob wrote:
> keep this?

Done.

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.cc#oldco...
src/ic/ic-state.cc:141: GENERATE(Token::BIT_AND, SMI, NUMBER, SMI,
OVERWRITE_RIGHT);
On 2015/02/05 10:21:57, Jakob wrote:
> keep this?
> 
> Ah, you know what, instead of manually comparing all these lines, let me
suggest
> the following algorithm to be applied to the old code:
> 
> 1.) s/, NO_OVERWRITE//, s/, OVERWRITE_LEFT//, s/, OVERWRITE_RIGHT//
> 2.) sort | uniq

Done.

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.h
File src/ic/ic-state.h (right):

https://codereview.chromium.org/900193002/diff/20001/src/ic/ic-state.h#newcod...
src/ic/ic-state.h:144: class ResultKindField : public BitField<Kind, 6, 3> {};
On 2015/02/05 10:21:57, Jakob wrote:
> Please either insert a comment that bits 4 and 5 are unused, or shift up the
> remaining BitFields to close the gap.

Done.

[Jakob Kummerow, 2015-02-05 10:35:57]

lgtm

[Benedikt Meurer, 2015-02-05 10:36:04]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-02-05 10:36:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900193002/40001

[Benedikt Meurer, 2015-02-05 10:38:21]

The CQ bit was unchecked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-02-05 10:39:38]

Patchset 3 (id:??) landed as
https://crrev.com/634b0f20f4bbdad305c87fd8e196f4c05efbde1f
Cr-Commit-Position: refs/heads/master@{#26454}

[Benedikt Meurer, 2015-02-05 10:40:06]

Committed patchset #3 (id:40001) manually as
634b0f20f4bbdad305c87fd8e196f4c05efbde1f (presubmit successful).