src/arm/lithium-codegen-arm.cc - Issue 900193002: Remove the obsolete OverwriteMode optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 900193002: Remove the obsolete OverwriteMode optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index e7f89822412edd30d62f41b2deb7e4b370b1edc6..1b12643fbc421f06b123b14ce2ef971f5597bf17 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -2184,8 +2184,7 @@ void LCodeGen::DoArithmeticT(LArithmeticT* instr) {

DCHECK(ToRegister(instr->right()).is(r0));

DCHECK(ToRegister(instr->result()).is(r0));

- Handle<Code> code =

- CodeFactory::BinaryOpIC(isolate(), instr->op(), NO_OVERWRITE).code();

+ Handle<Code> code = CodeFactory::BinaryOpIC(isolate(), instr->op()).code();

// Block literal pool emission to ensure nop indicating no inlined smi code

// is in the correct position.

Assembler::BlockConstPoolScope block_const_pool(masm());

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »