Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: src/full-codegen.h

Issue 900193002: Remove the obsolete OverwriteMode optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FULL_CODEGEN_H_ 5 #ifndef V8_FULL_CODEGEN_H_
6 #define V8_FULL_CODEGEN_H_ 6 #define V8_FULL_CODEGEN_H_
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
577 // Adds the properties to the class (function) object and to its prototype. 577 // Adds the properties to the class (function) object and to its prototype.
578 // Expects the class (function) in the accumulator. The class (function) is 578 // Expects the class (function) in the accumulator. The class (function) is
579 // in the accumulator after installing all the properties. 579 // in the accumulator after installing all the properties.
580 void EmitClassDefineProperties(ClassLiteral* lit); 580 void EmitClassDefineProperties(ClassLiteral* lit);
581 581
582 // Pushes the property key as a Name on the stack. 582 // Pushes the property key as a Name on the stack.
583 void EmitPropertyKey(ObjectLiteralProperty* property, BailoutId bailout_id); 583 void EmitPropertyKey(ObjectLiteralProperty* property, BailoutId bailout_id);
584 584
585 // Apply the compound assignment operator. Expects the left operand on top 585 // Apply the compound assignment operator. Expects the left operand on top
586 // of the stack and the right one in the accumulator. 586 // of the stack and the right one in the accumulator.
587 void EmitBinaryOp(BinaryOperation* expr, 587 void EmitBinaryOp(BinaryOperation* expr, Token::Value op);
588 Token::Value op,
589 OverwriteMode mode);
590 588
591 // Helper functions for generating inlined smi code for certain 589 // Helper functions for generating inlined smi code for certain
592 // binary operations. 590 // binary operations.
593 void EmitInlineSmiBinaryOp(BinaryOperation* expr, 591 void EmitInlineSmiBinaryOp(BinaryOperation* expr,
594 Token::Value op, 592 Token::Value op,
595 OverwriteMode mode,
596 Expression* left, 593 Expression* left,
597 Expression* right); 594 Expression* right);
598 595
599 // Assign to the given expression as if via '='. The right-hand-side value 596 // Assign to the given expression as if via '='. The right-hand-side value
600 // is expected in the accumulator. 597 // is expected in the accumulator.
601 void EmitAssignment(Expression* expr); 598 void EmitAssignment(Expression* expr);
602 599
603 // Shall an error be thrown if assignment with 'op' operation is perfomed 600 // Shall an error be thrown if assignment with 'op' operation is perfomed
604 // on this variable in given language mode? 601 // on this variable in given language mode?
605 static bool IsSignallingAssignmentToConst(Variable* var, Token::Value op, 602 static bool IsSignallingAssignmentToConst(Variable* var, Token::Value op,
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
1050 1047
1051 Address start_; 1048 Address start_;
1052 Address instruction_start_; 1049 Address instruction_start_;
1053 uint32_t length_; 1050 uint32_t length_;
1054 }; 1051 };
1055 1052
1056 1053
1057 } } // namespace v8::internal 1054 } } // namespace v8::internal
1058 1055
1059 #endif // V8_FULL_CODEGEN_H_ 1056 #endif // V8_FULL_CODEGEN_H_
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698