Files.app: Do not update cached MetadataCachedItemProperty before it is invalidated.

Files.app: Do not update cached MetadataCachedItemProperty before it is invalidated.

BUG=410766
TEST=FileManagerJsTest.MetadataCacheItem

Committed: https://crrev.com/6e88a1fd53c12f3d448b26bb4754b55ae3fb2d70
Cr-Commit-Position: refs/heads/master@{#314777}

[hirono, 2015-02-05 06:44:50]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-02-05 06:44:50]

PTAL the CL?
Actually I'm not sure the change is required or not.
But the behavior "cached item will not be changed unless it is invalidated"
makes it easier to follow the changes of cache from the client code of
MetadataCache.
Let me add the limitation now, and see whether it works or not.

[yawano, 2015-02-05 07:29:22]

lgtm with nit. Thank you!

https://codereview.chromium.org/900173002/diff/1/ui/file_manager/file_manager...
File
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js
(right):

https://codereview.chromium.org/900173002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js:146:
assertEquals('valueA1', results[0].propertyA);
nit: Could you add an assertion for propertyC to make clear that even when one
of properties(propertyA) is not set, other properties are set.

[hirono, 2015-02-05 07:58:45]

New patchsets have been uploaded after l-g-t-m from yawano@chromium.org

[hirono, 2015-02-05 07:59:41]

Thanks!

https://codereview.chromium.org/900173002/diff/1/ui/file_manager/file_manager...
File
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js
(right):

https://codereview.chromium.org/900173002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js:146:
assertEquals('valueA1', results[0].propertyA);
On 2015/02/05 07:29:22, yawano wrote:
> nit: Could you add an assertion for propertyC to make clear that even when one
> of properties(propertyA) is not set, other properties are set.

Done.

[hirono, 2015-02-05 07:59:43]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-05 08:00:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900173002/20001

[commit-bot: I haz the power, 2015-02-05 08:25:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-05 08:26:16]

Patchset 2 (id:??) landed as
https://crrev.com/6e88a1fd53c12f3d448b26bb4754b55ae3fb2d70
Cr-Commit-Position: refs/heads/master@{#314777}