ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js - Issue 900173002: Files.app: Do not update cached MetadataCachedItemProperty before it is invalidated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js

Issue 900173002: Files.app: Do not update cached MetadataCachedItemProperty before it is invalidated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js

diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js

index 663320f30de1a26b94d2096a7137db7389e6a50b..1efae04d9e4d73384a699f05bb6fced3584577bf 100644

--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js

+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js

@@ -62,8 +62,11 @@ MetadataCacheItem.prototype.storeProperties = function(requestId, object) {

for (var name in object) {

if (!this.properties_[name])

this.properties_[name] = new MetadataCacheItemProperty();

- if (requestId < this.properties_[name].requestId)

+ if (requestId < this.properties_[name].requestId ||

+ this.properties_[name].state ===

+ MetadataCacheItemPropertyState.FULFILLED) {

continue;

+ }

changed = true;

this.properties_[name].requestId = requestId;

this.properties_[name].value = object[name];

« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js » ('j') | no next file with comments »