ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js - Issue 900173002: Files.app: Do not update cached MetadataCachedItemProperty before it is invalidated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

Issue 900173002: Files.app: Do not update cached MetadataCachedItemProperty before it is invalidated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js ('k') | ui/file_manager/file_manager/foreground/js/metadata/new_metadata_provider_unittest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

index ca30f5f1d24cdace3f9d2bd0c0ff92b99ce30af3..4a5a04acba320d14fa7d9e8c38105291640b3af5 100644

--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

@@ -80,3 +80,11 @@ function testMetadataCacheItemHasFreshCache() {

assertFalse(item.hasFreshCache(['propertyA', 'propertyB']));

assertTrue(item.hasFreshCache(['propertyA']));

}

+function testMetadataCacheShouldNotUpdateBeforeInvalidation() {

+ var item = new MetadataCacheItem();

+ item.startRequests(1, item.createRequests(['property']));

+ item.storeProperties(1, {property: 'value1'});

+ item.storeProperties(2, {property: 'value2'});

+ assertEquals('value1', item.get(['property']).property);