Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 8992034: Merge 114608, 115692 to 963 (M17) branch. (Closed)

Created:
8 years, 12 months ago by Dan Beam
Modified:
8 years, 12 months ago
CC:
chromium-reviews, estade+watch_chromium.org, rginda+watch_chromium.org, achuith+watch_chromium.org, sail
Visibility:
Public.

Description

Merge 114608, 115692 to 963 (M17) branch. [Sync Promo UI] Changing sync promo to honor brand codes. Also, this CL moves chrome/browser/ui/webui/sync_promo_* to chrome/browser/ui/webui/sync_promo/sync_promo_*. BUG=107223 R=stevet@chromium.org,rogerta@chromium.org,sail@chromium.org TEST=The sync promo responds to brand code and records results of the field trial correctly. Review URL: http://codereview.chromium.org/8933003 [Sync Promo UI] Change data reporting to differentiate between startup and other means of getting to the full page sync promo. R=stevet@chromium.org,sail@chromium.org TEST=about:histograms, Ctrl+f "WithBrand" BUG=107223 Review URL: http://codereview.chromium.org/9007041 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115861

Patch Set 1 #

Patch Set 2 : removing unnecessary sync_promo_handler2.* #

Patch Set 3 : rebasing, checking for diffs before merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -908 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_login_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/sync_promo/sync_promo_handler.h View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
A + chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 1 2 6 chunks +22 lines, -15 lines 0 comments Download
A chrome/browser/ui/webui/sync_promo/sync_promo_trial.h View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc View 1 2 1 chunk +187 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/sync_promo/sync_promo_ui.h View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 2 6 chunks +22 lines, -4 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo_handler.h View 1 2 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo_handler.cc View 1 2 1 chunk +0 lines, -291 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo_trial.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo_trial.cc View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo_ui.h View 1 2 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/webui/sync_promo_ui.cc View 1 2 1 chunk +0 lines, -258 lines 0 comments Download
MM chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/chrome_browser.gypi View 1 2 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
8 years, 12 months ago (2011-12-25 09:20:16 UTC) #1
SteveT
Merge LGTM - but I just noticed that lint caught a couple errors worth fixing ...
8 years, 12 months ago (2011-12-25 17:43:37 UTC) #2
Dan Beam
On 2011/12/25 17:43:37, SteveT wrote: > Merge LGTM - but I just noticed that lint ...
8 years, 12 months ago (2011-12-25 19:13:04 UTC) #3
Dan Beam
+mirandac for OWNERS check
8 years, 12 months ago (2011-12-28 02:32:47 UTC) #4
Miranda Callahan
8 years, 12 months ago (2011-12-28 02:32:50 UTC) #5
On 2011/12/25 19:13:04, Dan Beam wrote:
> On 2011/12/25 17:43:37, SteveT wrote:
> > Merge LGTM - but I just noticed that lint caught a couple errors worth
fixing
> in
> > a separate nit CL and committing to mainline.
> 
> I noticed that as well. The one about include order is inside an #if/#else so
I
> think the linter got a little confused and I didn't think a 1 char diff was
> worth it, was just gonna fix next time I touch the file.

profiles/* LGTM

Powered by Google App Engine
This is Rietveld 408576698