Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3571)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

Issue 8992034: Merge 114608, 115692 to 963 (M17) branch. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/963/src/
Patch Set: rebasing, checking for diffs before merge Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
diff --git a/chrome/browser/ui/webui/sync_promo_handler.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
similarity index 91%
rename from chrome/browser/ui/webui/sync_promo_handler.cc
rename to chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
index 1287a4d2da99e7f264d666bf5454c600e61003c4..86e9454ed34ae9dbf7dbdcc5aca735c9b83b23a8 100644
--- a/chrome/browser/ui/webui/sync_promo_handler.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/webui/sync_promo_handler.h"
+#include "chrome/browser/ui/webui/sync_promo/sync_promo_handler.h"
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -15,8 +15,8 @@
#include "chrome/browser/tabs/tab_strip_model.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
-#include "chrome/browser/ui/webui/sync_promo_trial.h"
-#include "chrome/browser/ui/webui/sync_promo_ui.h"
+#include "chrome/browser/ui/webui/sync_promo/sync_promo_trial.h"
+#include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/pref_names.h"
@@ -122,16 +122,12 @@ void SyncPromoHandler::RegisterMessages() {
}
void SyncPromoHandler::ShowGaiaSuccessAndClose() {
- if (sync_promo_trial::IsExperimentActive())
- sync_promo_trial::RecordUserSignedIn();
-
+ RecordExperimentOutcomesOnSignIn();
SyncSetupHandler::ShowGaiaSuccessAndClose();
}
void SyncPromoHandler::ShowGaiaSuccessAndSettingUp() {
- if (sync_promo_trial::IsExperimentActive())
- sync_promo_trial::RecordUserSignedIn();
-
+ RecordExperimentOutcomesOnSignIn();
SyncSetupHandler::ShowGaiaSuccessAndSettingUp();
}
@@ -183,11 +179,11 @@ void SyncPromoHandler::StepWizardForShowSetupUI() {
}
void SyncPromoHandler::ShowSetupUI() {
- // SyncSetupWizard::Step should be called in StepWizardForShowSetupUI above,
- // but it causes the sync promo page to not set focus properly to the login
- // email address. This happens because focus is lost between the call to
- // StepWizardForShowSetupUI and ShowSetupUI.
- // TODO(binji): Move this function back and fix the focus the right way.
+ // SyncSetupWizard::Step should be called in StepWizardForShowSetupUI above,
+ // but it causes the sync promo page to not set focus properly to the login
+ // email address. This happens because focus is lost between the call to
+ // StepWizardForShowSetupUI and ShowSetupUI.
+ // TODO(binji): Move this function back and fix the focus the right way.
ProfileSyncService* service =
Profile::FromWebUI(web_ui_)->GetProfileSyncService();
service->get_wizard().Step(SyncSetupWizard::GetLoginState());
@@ -276,7 +272,7 @@ int SyncPromoHandler::GetViewCount() const {
return prefs_->GetInteger(prefs::kSyncPromoViewCount);
}
-int SyncPromoHandler::IncrementViewCountBy(unsigned int amount) {
+int SyncPromoHandler::IncrementViewCountBy(size_t amount) {
// Let the user increment by 0 if they really want. It might be useful for a
// weird way of sending preference change notifications...
int adjusted = GetViewCount() + amount;
@@ -284,6 +280,17 @@ int SyncPromoHandler::IncrementViewCountBy(unsigned int amount) {
return adjusted;
}
+void SyncPromoHandler::RecordExperimentOutcomesOnSignIn() {
+ if (sync_promo_trial::IsExperimentActive())
+ sync_promo_trial::RecordUserSignedIn();
+ if (sync_promo_trial::IsPartOfBrandTrialToEnable()) {
+ bool is_start_up = SyncPromoUI::GetIsLaunchPageForSyncPromoURL(
+ web_ui_->tab_contents()->GetURL());
+ Profile* profile = Profile::FromWebUI(web_ui_);
+ sync_promo_trial::RecordUserSignedInWithTrialBrand(is_start_up, profile);
+ }
+}
+
void SyncPromoHandler::RecordUserFlowAction(int action) {
// Send an enumeration to our single user flow histogram.
UMA_HISTOGRAM_ENUMERATION("SyncPromo.UserFlow", action,
« no previous file with comments | « chrome/browser/ui/webui/sync_promo/sync_promo_handler.h ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_trial.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698