Issue 9007041: [Sync Promo UI] Change data reporting to differentiate between startup and other

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9007041: [Sync Promo UI] Change data reporting to differentiate between startup and other (Closed)

Created:
9 years ago by Dan Beam

Modified:
9 years ago

Reviewers:
SteveT, sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Sync Promo UI] Change data reporting to differentiate between startup and other means of getting to the full page sync promo. R=stevet@chromium.org,sail@chromium.org TEST=about:histograms, Ctrl+f "WithBrand" BUG=107223 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115692

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -24 lines)			Patch
M	chrome/browser/ui/webui/sync_promo/sync_promo_handler.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc	View	2 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_trial.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_trial.cc	View	3 chunks	+23 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_ui.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc	View	4 chunks	+13 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9007041/1

9 years ago (2011-12-23 04:18:10 UTC) #4

Change committed as 115692